all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@linkov.net>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master dde0320: * lisp/replace.el (replace-highlight): Add save-match-data (bug#36328)
Date: Fri, 05 Jul 2019 16:24:13 -0400	[thread overview]
Message-ID: <jwv4l40i62k.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20190705191141.C019D20552@vcs0.savannah.gnu.org> (Juri Linkov's message of "Fri,  5 Jul 2019 15:11:41 -0400 (EDT)")

> -	(isearch-lazy-highlight-new-loop range-beg range-end))))
> +	(save-match-data
> +	  ;; Preserve match-data for perform-replace since

Then the save-match-data should be in perform-replace, not here,
I think.


        Stefan




       reply	other threads:[~2019-07-05 20:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190705191140.31351.77660@vcs0.savannah.gnu.org>
     [not found] ` <20190705191141.C019D20552@vcs0.savannah.gnu.org>
2019-07-05 20:24   ` Stefan Monnier [this message]
2019-07-07 22:18     ` [Emacs-diffs] master dde0320: * lisp/replace.el (replace-highlight): Add save-match-data (bug#36328) Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv4l40i62k.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.