From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master a6b5985: Avoid duplicated character classes in rx Date: Tue, 03 Dec 2019 12:39:57 -0500 Message-ID: References: <20191203142243.9552.27513@vcs0.savannah.gnu.org> <20191203142246.0615C20A2B@vcs0.savannah.gnu.org> <79A83C7D-610F-4CA4-B5E9-7F11FD8A9365@acm.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="162731"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Mattias =?windows-1252?Q?Engdeg=E5rd?= , Emacs developers To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 03 19:29:00 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1icCuy-000g6e-5J for ged-emacs-devel@m.gmane.org; Tue, 03 Dec 2019 19:29:00 +0100 Original-Received: from localhost ([::1]:57266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icCuv-0007Oh-WB for ged-emacs-devel@m.gmane.org; Tue, 03 Dec 2019 13:28:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60745) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icCOP-00018y-HM for emacs-devel@gnu.org; Tue, 03 Dec 2019 12:55:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icC9e-0002OX-B8 for emacs-devel@gnu.org; Tue, 03 Dec 2019 12:40:08 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17792) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1icC9e-0002CL-2v for emacs-devel@gnu.org; Tue, 03 Dec 2019 12:40:06 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 21B76100473; Tue, 3 Dec 2019 12:40:03 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 77F261000B0; Tue, 3 Dec 2019 12:40:01 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1575394801; bh=DgQkesSu3IVKBfXaqsIKUmErL5EzEvg2uIy8SgUUs9c=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=oX2PT5GOjJQNZw5/pyUx7J5FnRn3qhmktEsmQ2J8T6H5FRTpwlxZx4CT4tMxu/u05 b/FUrVxTlaICCxNRYC5GIrVXiaq/LU0Gd9wTOdNZx5RmGElLDUC4YHhv0ik3xvhJqP TKaICLSXWgX0cEYfpWY/irDM3kQj2LWwN5aGK7mYq71/kuWbOyF6S6b2zlfS/sn4Q6 LXOMPOY7BNoBVjZ8G9uGTKLwacpRVUqdQyj9LmjX323tY/KWBu9+Y7/JnTs6PNHzTO pqXXQgah1VNqBM0oNWuzOTLhtVZ2mJVI22USoEBg+/8m9bIWl9Ca0hX58uBZHLHtI3 rYuA4k0KABuGw== Original-Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 35445120FF6; Tue, 3 Dec 2019 12:40:01 -0500 (EST) In-Reply-To: (Juanma Barranquero's message of "Tue, 3 Dec 2019 17:06:16 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243071 Archived-At: >> Probably, but I still think it's bad practice to use the return value of >> an operation which is fundamentally a side-effect. > So you've never written > (if (setq var value) ...) Guilty as charged. But every time I do so I feel a bit dirty (and not just because I feel dirty every time I use `setq`). And I have often regretted writing such code. To my defense, `setq` is the only such exception I can think of. Stefan