From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master ce4ec17: Fix display-buffer-override-next-command to call action only once (bug#39722) Date: Sun, 21 Jun 2020 23:38:10 -0400 Message-ID: References: <20200621233622.23590.68753@vcs0.savannah.gnu.org> <20200621233623.C811520A26@vcs0.savannah.gnu.org> <87lfkgj5tk.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="46066"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 22 05:38:50 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jnDII-000BsE-9o for ged-emacs-devel@m.gmane-mx.org; Mon, 22 Jun 2020 05:38:50 +0200 Original-Received: from localhost ([::1]:33558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnDIH-0006Pc-CJ for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Jun 2020 23:38:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnDHl-0005yd-2L for emacs-devel@gnu.org; Sun, 21 Jun 2020 23:38:17 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:59993) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnDHi-0001R7-3q for emacs-devel@gnu.org; Sun, 21 Jun 2020 23:38:16 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DAC064406EF; Sun, 21 Jun 2020 23:38:12 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 501A44406EB; Sun, 21 Jun 2020 23:38:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1592797091; bh=6ae0h8emrNUZHdCXcIZiQOHVJzTFoLzHTnnYrrhj8m0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=oldLE1JzJFMqWrUu9b+ggJJ7JetkVBPvYpAU+dS9SQbwvAkDJraY+mkh8vzyVQSWz 5FJaFyd9a3t7NWlVTOIJO4ESdtkwGACUEv04FNab/Ubhk8PWKNG7Ka0i/nWH7WMyGO HkX6Amd02CySV433bmB68yIDIqJipTPCIyUeSrHaqZubi8S3IWG4QWcb8mmlpZHRDM NXdw5VUd0xSbbazsDNKvMbpQ4tG9jCsLN6hu9FWBqCeq/LoVU7VD5Rmh1JVGAmM7GD 4BZkZbIjvuKWlDs5T4DgVqgglQbAK7y2OTDfRSHtovShYznWb2Mj2ydQGRovgu00Fo TGKs3exbTveAA== Original-Received: from alfajor (unknown [108.175.228.207]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1A0081201B3; Sun, 21 Jun 2020 23:38:11 -0400 (EDT) In-Reply-To: <87lfkgj5tk.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 22 Jun 2020 03:35:19 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/21 23:38:13 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252507 Archived-At: >>> Fix display-buffer-override-next-command to call action only once (bug#39722) >> How do prefix commands using `display-buffer-override-next-command` >> interact with other prefix commands such as `C-u`? > They play nicely with all prefix commands, and even with the minibuffer: > display-buffer-override-next-command comes into play only after exiting > the minibuffer. I'm not sure how. I think `C-x 4 4` followed by `C-u` will work thanks to the (eq this-command command) check (because `prefix-command-preserve-state` does (setq this-command last-command)), but I don't think the reverse will work. Another problem I see in the code is that `display-buffer-override-next-command` does (setq display-buffer-overriding-action (delq action display-buffer-overriding-action)) [...] (push action display-buffer-overriding-action))) But `display-buffer-overriding-action` is not supposed to hold a list of actions. >> Any chance this can be merged/unified with `other-frame-window` code? > What features do you miss from other-frame-window? I'm not really worried about features but more about the code and about what we've learned about the detailed interactions (i.e. trying to avoid reinventing the same not-quite-circular wheel). In terms of features (besides the extra transient keymap which allows the use of shorter `C-x 4` and `C-x 5` prefixes and special bindings under those prefixes) I suspect that there's the echo area feedback that's missing, tho I'm not sure it works really well yet in `other-frame-window`. Stefan