From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Recursive Fload and eval-after-load forms. (See bug #43116.) Date: Mon, 31 Aug 2020 23:18:35 -0400 Message-ID: References: <20200831184526.GB4176@ACM> <20200831194238.GC4176@ACM> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21064"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Nonax , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 01 05:19:33 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCwpZ-0005PP-MG for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Sep 2020 05:19:33 +0200 Original-Received: from localhost ([::1]:56108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCwpY-0002Pr-NX for ged-emacs-devel@m.gmane-mx.org; Mon, 31 Aug 2020 23:19:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCwok-0001Wp-S2 for emacs-devel@gnu.org; Mon, 31 Aug 2020 23:18:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60193) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCwoi-0002pT-28 for emacs-devel@gnu.org; Mon, 31 Aug 2020 23:18:41 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 49034809AC; Mon, 31 Aug 2020 23:18:38 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BB66380608; Mon, 31 Aug 2020 23:18:36 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1598930316; bh=69pER9iNhqXxG3tAgkW8cc9t9Fb3cvV/x5GQuKphMxs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=mU/WcxGGF1lic/z26f1tin0kugr8XL8pWRSBsFmMEC9pVIgP5MauddimC+BE2RLrt fHXx6wdiz/+VNGzt21ARWILIpqMOq89kP4l+UCkrd+SpyxnV5HMR29CQaQeCgW5t6D WoXLmgCmguZZDL6x3sOAEO+HD2aXS9KWHZ9OzcCsfZS2Oap/8FqRLA9Bz2+lcBx9mb rvqb2uCON0MRKy6/Ph+tDmS/678xENlP7IsjS0VWJcnJnwmVGa+4QWWwIbsP2Ig5h5 YsGEfaFwwhuutcfg7em0m2aE1jdimSUxkB/syy24tiLAiG2nSbO1CEMUyijBlgJn7e AzFT9XAMJ1LuQ== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 899561202C2; Mon, 31 Aug 2020 23:18:36 -0400 (EDT) In-Reply-To: <20200831194238.GC4176@ACM> (Alan Mackenzie's message of "Mon, 31 Aug 2020 19:42:38 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/31 23:18:38 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254461 Archived-At: > Fload bails out with an error if the nesting of files it's loading has > a file more than three times in the stack. Indeed, we know that recursive loads do exist and don't always end up inf-looping, so we only signal an infinite recursive load when it looks *really* bad ;-) > Maybe instead we could modify custom-menu-create such that it will only > require its target file if that file isn't currently being loaded. We could try that. Or we could make it return a dynamic menu whose content is only computed when the menu is actually displayed. > If it is currently being loaded, then we only include the customisable > variables that have already been defined. This shouldn't be too much > of a hardship, since custom variables tend to be defined near the > start of a .el file, and the higher level functions which create the > custom menu tend to be nearer the end of the file. > > What do you think? According to `grep` it would be good enough for the 3 use cases we have bundled with Emacs. Stefan