From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v2 03/16] Stop checking the constant default for enable_multibyte_characters Date: Wed, 25 Nov 2020 15:57:59 -0500 Message-ID: References: <20201119153814.17541-1-sbaugh@catern.com> <0061a5f55e91cc4f62265bb3ccb67d07e8e9a1dd.1606009917.git.sbaugh@catern.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16507"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Arnold Noronha , Dmitry Gutov , emacs-devel@gnu.org To: Spencer Baugh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 25 22:08:15 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ki21O-0004Cn-SP for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Nov 2020 22:08:14 +0100 Original-Received: from localhost ([::1]:48450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ki21N-00016R-Ts for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Nov 2020 16:08:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ki1ra-00014Y-QD for emacs-devel@gnu.org; Wed, 25 Nov 2020 15:58:11 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33301) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ki1rX-0003eO-Qk for emacs-devel@gnu.org; Wed, 25 Nov 2020 15:58:06 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id ED5EC8009B; Wed, 25 Nov 2020 15:58:02 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6D33280853; Wed, 25 Nov 2020 15:58:01 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1606337881; bh=YDB55CBs9idmxAzj0BVHqixPmCTU+kYZy4jvOcNNIFI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=LgDGQJUWQ/4Q+8+fCS43ynREzYMuVr2QfI6t1AbsaPihgDkAfBG65fL+YobsVp75I 40UuPhNpH4H4gvus7lHwuk4CAl+3MWfVPdm9tYWD93eQc8h5XnT+2VdpkDGQYHJOzS OpR7Tf3udZHV5U5iRC/SxkZrgA7AY1Vpt2VLUrwF9C8TllRAkkJqUq6Jr8tAVpTkLh o3No3s9yV7NJhW/GkDqBWOxf5pTwZgKe8YhPevNiwzQ0gERKFx6wStNKzJ5S6IRNlF doPzlI+zBq57phWADuXylJJXHjLp7UG2TYgFDdK6tN1xxFxED6+iSOIuFM+Wm4H33w 5IWSAPyz5GPlA== Original-Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1F733120314; Wed, 25 Nov 2020 15:58:01 -0500 (EST) In-Reply-To: <0061a5f55e91cc4f62265bb3ccb67d07e8e9a1dd.1606009917.git.sbaugh@catern.com> (Spencer Baugh's message of "Sat, 21 Nov 2020 21:34:32 -0500") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259811 Archived-At: > The default is a constant "t", and can't be changed. So we don't need > to check it. Indeed. It used to be changeable (running so-called "unibyte sessions"), but that was removed several years ago. This, like several other of the changes in this series, is not directly related to the "speed up PER_BUFFER" change. You might want to keep them in a separate patch series to help the review. Stefan