From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: master 6e796b5: Stop project-root from going into infinite recursion
Date: Wed, 17 Mar 2021 17:33:13 -0400 [thread overview]
Message-ID: <jwv4kh9ii8c.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20210317164928.C2C11209AA@vcs0.savannah.gnu.org> (Dmitry Gutov's message of "Wed, 17 Mar 2021 12:49:28 -0400 (EDT)")
> @@ -215,7 +217,9 @@ It usually contains the main build file, dependencies
> configuration file, etc. Though neither is mandatory.
>
> The directory name must be absolute."
> - (car (project-roots project)))
> + (if project--within-roots-fallback
> + (signal 'cl-no-applicable-method (list 'project-root project))
> + (car (project-roots project))))
I think `cl-call-next-method` is a better choice.
Stefan
next parent reply other threads:[~2021-03-17 21:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210317164927.28196.12402@vcs0.savannah.gnu.org>
[not found] ` <20210317164928.C2C11209AA@vcs0.savannah.gnu.org>
2021-03-17 21:33 ` Stefan Monnier [this message]
2021-03-17 21:52 ` master 6e796b5: Stop project-root from going into infinite recursion Dmitry Gutov
2021-03-17 22:29 ` Stefan Monnier
2021-03-18 0:37 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4kh9ii8c.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.