From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#49534: 26.3; Isearch should support using filter predicates with empty search hits Date: Tue, 13 Jul 2021 18:48:39 -0400 Message-ID: References: <87czrmrxfv.fsf@gnus.org> <87zguq6mof.fsf@mail.linkov.net> <874kcy6k4l.fsf@mail.linkov.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10875"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 49534@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 14 00:49:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3RDH-0002bj-AU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Jul 2021 00:49:15 +0200 Original-Received: from localhost ([::1]:34322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3RDG-0006ZR-0n for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Jul 2021 18:49:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3RD4-0006Xx-Cq for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2021 18:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59035) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3RD4-000057-4K for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2021 18:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m3RD3-0007mJ-Pb for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2021 18:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jul 2021 22:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 49534-submit@debbugs.gnu.org id=B49534.162621653429887 (code B ref 49534); Tue, 13 Jul 2021 22:49:01 +0000 Original-Received: (at 49534) by debbugs.gnu.org; 13 Jul 2021 22:48:54 +0000 Original-Received: from localhost ([127.0.0.1]:42348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3RCw-0007lz-6u for submit@debbugs.gnu.org; Tue, 13 Jul 2021 18:48:54 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3RCq-0007lh-2Z for 49534@debbugs.gnu.org; Tue, 13 Jul 2021 18:48:52 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id AFEC0440B00; Tue, 13 Jul 2021 18:48:41 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 53622440B1D; Tue, 13 Jul 2021 18:48:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1626216520; bh=oHpUG0FW9MKxx8bquhXTqmDMVjIXp4fnb8kO60m5Gdo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=BT3GWc/x4qM3ByaYE/zBlvgNnOnerXW3FRYRbsS9rO5O+93DfJhIt109pxnGz+QzA UZJnrrofLHIUjcYz/Sx+G6SW+eurX9/y+kTh9D3GRbQPSfwFU1VijpKfSbGk70CmSM BZHGHqTr2sCy1nSHZmu5EqftF2Npy10Qh0kKmqRGQcenmZpolp+Hic+dKennFNFxoV P8yK8DlXGI/rfQzoyWUz4hBonI/m5OvaI/sVZ7EoX2mtat+o8X/Te55kPsmQNp3F6N K65cIVGsEA6+I2s28Ow0Ic3tzMNMrfCaslUThTUVbxm3dpVXGkuSMKxlFRNoVGVenh 2a1xnMDONU3AQ== Original-Received: from alfajor (unknown [216.154.29.138]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1AA91120189; Tue, 13 Jul 2021 18:48:40 -0400 (EDT) In-Reply-To: <874kcy6k4l.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 13 Jul 2021 23:20:42 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209899 Archived-At: > This means that if isearch-filter-predicate does own matching, > it will break later (= (match-beginning 0) (match-end 0)). > What would be better: to remember its result in a let-bound variable, > or to use save-match-data? Probably, save-match-data: Remembering the result in a var might be more efficient. Also if `isearch-filter-predicate` clobbers the match data we have more problems (unless it tells us to skip this match). But whichever choice we make I think the docstring of `isearch-filter-predicate` should clarify what happens with the match data (i.e. whether it needs to be careful not to clobber it or not). Stefan