From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#49788: 28.0.50; [PATCH] Package archive location needs to be absolute Date: Sat, 31 Jul 2021 12:32:48 -0400 Message-ID: References: <87a6m3b7wj.fsf@dick> <83o8ajov5k.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21219"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: dick.r.chiang@gmail.com, 49788@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 31 18:33:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9rvD-0005KN-6R for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Jul 2021 18:33:11 +0200 Original-Received: from localhost ([::1]:56822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9rvB-0004Wi-98 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Jul 2021 12:33:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9rv4-0004WW-MJ for bug-gnu-emacs@gnu.org; Sat, 31 Jul 2021 12:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51395) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m9rv4-0005p5-Eq for bug-gnu-emacs@gnu.org; Sat, 31 Jul 2021 12:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m9rv4-0002sS-Ae for bug-gnu-emacs@gnu.org; Sat, 31 Jul 2021 12:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Jul 2021 16:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49788 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49788-submit@debbugs.gnu.org id=B49788.162774917911051 (code B ref 49788); Sat, 31 Jul 2021 16:33:02 +0000 Original-Received: (at 49788) by debbugs.gnu.org; 31 Jul 2021 16:32:59 +0000 Original-Received: from localhost ([127.0.0.1]:34708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9rv0-0002sA-U1 for submit@debbugs.gnu.org; Sat, 31 Jul 2021 12:32:59 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:8149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9ruz-0002rx-0J for 49788@debbugs.gnu.org; Sat, 31 Jul 2021 12:32:57 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6E52980436; Sat, 31 Jul 2021 12:32:51 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2DD368089C; Sat, 31 Jul 2021 12:32:50 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1627749170; bh=yfP8FJ+w++jsYe6MI588p0BLzZv9sgk0buXwHa2vCKs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DGKSLjUxpVk+E7tUVp6yGu7hOqTq7j0gmb9HGvFeUowkeCEIvBLgXVC3nJdUQMPYQ y3HcLuMfbhtAkwh84cdpHUPsm5EmiDKoJVRBBmzlSvi42w4eDeqCkyuR3Vahvbw8nz JACg+amCLUA67C/F2/F0uTjuetFtvyBYFbMU8dECqVrMddJKC8u+HbwyYM8RQqRE/y P8FSh2SnU3RZiK3C44Lu0ELjajbVEX6RyPhfeKWQzufS0Vx4ZJSwuf0JBtQwjcm4Di qGVUCjbTtQY5/chFQQDFLu11tNF80pFxx3KVL+pOa4xPKPJ8AKxjJJuVtXlB+oyoSd L+qpN7mmq1c4g== Original-Received: from alfajor (unknown [216.154.29.138]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E9BF3120533; Sat, 31 Jul 2021 12:32:49 -0400 (EDT) In-Reply-To: <83o8ajov5k.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 31 Jul 2021 09:27:19 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211002 Archived-At: >> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el >> index f1daa8d124..dfda201af6 100644 >> --- a/lisp/emacs-lisp/package.el >> +++ b/lisp/emacs-lisp/package.el >> @@ -1366,10 +1366,10 @@ package--with-response-buffer-1 >> (kill-buffer buffer) >> (goto-char (point-min)))))) >> (package--unless-error body >> + (unless (file-name-absolute-p url) >> + (error "Location %s is not a url nor an absolute file name" >> + url)) >> (let ((url (expand-file-name file url))) >> - (unless (file-name-absolute-p url) >> - (error "Location %s is not a url nor an absolute file name" >> - url)) >> (insert-file-contents-literally url))))) >> >> (define-error 'bad-signature "Failed to verify signature") > > Hmm.. if we require it to be an absolute file name, why run it through > expand-file-name? > > Stefan, any comments? It's not the same `url` we're talking about. The `file` argument is relative, and the `url` argument should be absolute. Stefan