From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64757: 30.0.50; Declare `defadvice` obsolete Date: Fri, 21 Jul 2023 11:26:04 -0400 Message-ID: References: <83r0p1252n.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29707"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64757@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 21 17:27:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qMs2H-0007St-5i for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jul 2023 17:27:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMs24-0002Jf-I2; Fri, 21 Jul 2023 11:27:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMs23-0002JN-G6 for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 11:27:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMs23-0005BD-7u for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 11:27:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMs22-000545-AU for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 11:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jul 2023 15:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64757 X-GNU-PR-Package: emacs Original-Received: via spool by 64757-submit@debbugs.gnu.org id=B64757.168995317419386 (code B ref 64757); Fri, 21 Jul 2023 15:27:02 +0000 Original-Received: (at 64757) by debbugs.gnu.org; 21 Jul 2023 15:26:14 +0000 Original-Received: from localhost ([127.0.0.1]:34507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMs1G-00052X-CS for submit@debbugs.gnu.org; Fri, 21 Jul 2023 11:26:14 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:48903) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMs1E-00052J-CF for 64757@debbugs.gnu.org; Fri, 21 Jul 2023 11:26:13 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DF8C31000C3; Fri, 21 Jul 2023 11:26:06 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 87A4E10006C; Fri, 21 Jul 2023 11:26:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689953165; bh=Ttsiwbo0KtNc6qgnZD5sdfdwUPSCdt2xoc7e+rLFV0w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=c8fOkrS87zh22hiI1WBggo3lRl0xzra/ha2EpnggbmkVxO2EJv2D909tJS8x6UuuG HvTH0I8ESo90pte0oWOZ2uAchWXOpNF3x3QZgO0LSDY5iw5v9REJgS8QaLpqW66dJN O7CXbJhXmB86GrmxfDF9C/G9KAQ2jQ0+OjNqReRcDWEaVpYLQw0EQ7vOL7uktgIqJB 5VOWIwbv9TR8bQTIly7prXN4EKN8UPYweKCwr7jGMiNV1CE/ZJBiBrziHXxba7MxQM ukDGKO1PsqqENHlh1kGlrpnjr4zADaG/CEtBOurFBEFa/VLCTPyKNEBanmN8wpbiM6 +oU39nX505DVA== Original-Received: from alfajor (unknown [23.233.149.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5D39A12030A; Fri, 21 Jul 2023 11:26:05 -0400 (EDT) In-Reply-To: <83r0p1252n.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 21 Jul 2023 08:42:40 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265727 Archived-At: > ...this is too terse. We need to mention the two alternatives to > defadvice, including pointers to the ELisp manual's nodes. People who > still use defadvice will need those to convert their programs. Something like that? Stefan diff --git a/etc/NEWS b/etc/NEWS index c50f560282a..d22969444db 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -610,6 +610,10 @@ provokes an error if used numerically. * Lisp Changes in Emacs 30.1 +** 'defadvice' is marked as obsolete. +See (info "(elisp)Porting Old Advice") for help converting them +to use `advice-add` or `define-advice instead. + +++ ** New user option 'safe-local-variable-directories'. This user option names directories in which Emacs will treat all diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el index 56f0ae2212c..3265809f592 100644 --- a/lisp/emacs-lisp/advice.el +++ b/lisp/emacs-lisp/advice.el @@ -3131,6 +3131,7 @@ defadvice [DOCSTRING] [INTERACTIVE-FORM] BODY...)" (declare (doc-string 3) (indent 2) + (obsolete "use advice-add or define-advice" "30.1") (debug (&define name ;; thing being advised. (name ;; class is [&or "before" "around" "after" ;; "activation" "deactivation"]