From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61396: diff mode could distinguish changed from deleted lines Date: Thu, 14 Sep 2023 21:34:19 -0400 Message-ID: References: <85f73356-3a11-c76c-dd9a-f2dc1f6ef504@gutov.dev> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36715"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61396@debbugs.gnu.org, Samuel Wales To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 15 03:35:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qgxju-0009NT-EZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Sep 2023 03:35:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgxjW-0007Qj-UF; Thu, 14 Sep 2023 21:34:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgxjU-0007QX-L0 for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2023 21:34:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgxjU-0003R7-2m for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2023 21:34:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qgxja-0003K4-6C for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2023 21:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Sep 2023 01:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61396 X-GNU-PR-Package: emacs Original-Received: via spool by 61396-submit@debbugs.gnu.org id=B61396.169474167812739 (code B ref 61396); Fri, 15 Sep 2023 01:35:02 +0000 Original-Received: (at 61396) by debbugs.gnu.org; 15 Sep 2023 01:34:38 +0000 Original-Received: from localhost ([127.0.0.1]:41524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgxjB-0003JP-U3 for submit@debbugs.gnu.org; Thu, 14 Sep 2023 21:34:38 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:48785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgxj7-0003J8-Kr for 61396@debbugs.gnu.org; Thu, 14 Sep 2023 21:34:36 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 999698071E; Thu, 14 Sep 2023 21:34:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1694741660; bh=34TFJb0rHFqD95lU/GRttkqfQpAK5AxOagl+ktOWJpY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=IZmmdh0ts5xiqFwUXvUr0U07mZgukK6EB7Jn/Z+sNKIW+t1mZsNFHdZlTNYc8NByT V+s2wtSMZjV459k7OZhshULDSrPCYkKDZjIdnDzXAk0Z5sP9GQlptnUTZOyalGqw2C HsvcnpSsDDmF5VGoyRrDISJu42/sxcuWOHom6XeRap1LKiXCpSZDjpey/iW97q1sjk I5MqK/IWYEib43wkueDx2kQnWJnhpvxqw/f72qcWz8DOl6UZx5UU+y3yQ1ynaHgAZs wKPaFVlZVynUTirFP1GTmv5JHHyXYdF1x5EbV8FSRML96iAIMvOWuSTr30jzzN5E9E g0+kjzHboNkww== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5661080385; Thu, 14 Sep 2023 21:34:20 -0400 (EDT) Original-Received: from pastel (unknown [104.247.229.91]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2A5AF12030B; Thu, 14 Sep 2023 21:34:20 -0400 (EDT) In-Reply-To: (Dmitry Gutov's message of "Fri, 15 Sep 2023 01:42:45 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270469 Archived-At: > - Like Samuel mentioned, attenuate the indicators' column. Except instead of > inverse video just apply the refine faces? See > diff-refine-indicators.png. Looks good to me color-wise, though the change > in the indication method is somewhat an inconsistency. I think I like that. But I'm not sure how to adapt this to my case where I "prettify" the indicators into the fringe. Maybe a related idea would be to use the diff-refine-added/removed face on the line-end: the reduced contrast is not a problem there since there's no text. But it's not always visible (for long enough lines). I suspect we'll have to provide various alternatives and see which ones stick. Stefan