From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/counsel 14c696aa2d 1/2: Prefer Emacs 27 (TICKS . HZ) time values Date: Thu, 29 Feb 2024 12:54:59 -0500 Message-ID: References: <170921991732.23167.11490635005347998872@vcs2.savannah.gnu.org> <20240229151837.A73A5C12C4D@vcs2.savannah.gnu.org> <87cysfs0yu.fsf@epfl.ch> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11676"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 29 18:55:47 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rfkdG-0002pc-HM for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Feb 2024 18:55:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rfkcf-0006DR-2l; Thu, 29 Feb 2024 12:55:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfkcc-0006CG-6L for emacs-devel@gnu.org; Thu, 29 Feb 2024 12:55:06 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfkca-0005Qs-CL for emacs-devel@gnu.org; Thu, 29 Feb 2024 12:55:05 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B4F4680468; Thu, 29 Feb 2024 12:55:01 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1709229300; bh=4kf3kpsOiGe7PKSAEtGgPb8B2ijIvuyX+nDzoAmTfFU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=er6vWd5UDB/TcpYUu/paWBPzxTIEE2h3sPFHq8BH+GMid0z2k+jyEwYT5S4j8NgsM sZtZ3UN99fPlov+tGvWpfaJcihU8AvyKtuYRL6DHMEL5yRXfvMlHe4MDiadYPVFNAe 59oean72ypudCTLiBsO9tiwfU1FkwOzBlQ4UaSPEsIFfHZEHmhKSWZ042HTzBCUL1o DFelXSj9YJMrKZlfT3AKQAhOTOj/QLkZS+/kdwXslOiqYB3IggrUUk7L0dHcId28Tw +pCM2KfxL9tl5L8uAUhetqjjdAPu/X8OcM8/9GIz0qD/L0gfv/ShRecTfvQnsLMxgf L9yUNuF65luFw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6CABC806EF; Thu, 29 Feb 2024 12:55:00 -0500 (EST) Original-Received: from alfajor (modemcable005.21-80-70.mc.videotron.ca [70.80.21.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4EAAB120787; Thu, 29 Feb 2024 12:55:00 -0500 (EST) In-Reply-To: <87cysfs0yu.fsf@epfl.ch> (Basil L. Contovounesios's message of "Thu, 29 Feb 2024 17:13:13 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316647 Archived-At: >>> +(defalias 'counsel--async-filter-update-time >>> + (if (fboundp 'time-convert) >>> + ;; Preferred (TICKS . HZ) format since Emacs 27.1. >>> + (lambda () (cons counsel-async-filter-update-time 1000000)) >> >> Why not use `time-convert` rather than hardcode the internal representation? > > It wasn't clear to me that any of these options is better: > > 1. (time-convert (/ counsel-async-filter-update-time 1e6) t) > 2. (time-convert (cons counsel-async-filter-update-time 1000000) t) Yeah, I guess all alternatives are about as good/bad. Nevermind, Stefan