From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70868: 30.0.50; Date: Tue, 14 May 2024 18:30:48 -0400 Message-ID: References: <663fb841.050a0220.ffcbb.b84f@mx.google.com> <86jzk019u0.fsf@gnu.org> <86h6f419mi.fsf@gnu.org> <87v83jozi7.fsf@web.de> <86ikzjysrh.fsf@gnu.org> <87r0e7oyct.fsf@web.de> <86frunyr3o.fsf@gnu.org> <87cypomesl.fsf@web.de> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="619"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , iarchivedmywholelife@gmail.com, 70868@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 15 00:31:32 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s70gE-000AXm-QN for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 May 2024 00:31:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s70fv-0000TX-I9; Tue, 14 May 2024 18:31:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s70fl-0000TB-Fl for bug-gnu-emacs@gnu.org; Tue, 14 May 2024 18:31:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s70fl-0005QW-4w for bug-gnu-emacs@gnu.org; Tue, 14 May 2024 18:31:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s70fm-0006HF-9w for bug-gnu-emacs@gnu.org; Tue, 14 May 2024 18:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 May 2024 22:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70868 X-GNU-PR-Package: emacs Original-Received: via spool by 70868-submit@debbugs.gnu.org id=B70868.171572586124123 (code B ref 70868); Tue, 14 May 2024 22:31:02 +0000 Original-Received: (at 70868) by debbugs.gnu.org; 14 May 2024 22:31:01 +0000 Original-Received: from localhost ([127.0.0.1]:41519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s70fk-0006H1-N0 for submit@debbugs.gnu.org; Tue, 14 May 2024 18:31:00 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:18566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s70fh-0006Gt-55 for 70868@debbugs.gnu.org; Tue, 14 May 2024 18:30:59 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A89C88098B; Tue, 14 May 2024 18:30:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1715725848; bh=GUV8MgRw8B7lRanIUToUqOXndo/iG4j4dibd8VNPSk0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=OkmmxSx6Twdcz8dZ6b3SDuHat74uZZyb7RFQ59I+rXTmnOWLhjcfkkcZBwMplP5oy X+L4VReTSe8SAlYP3y2/th6Y8JAuhzxhHoWDXTHMq1d787RHvkjS3TowtWbYa6u92k MSn4Vy4n9t7P+xKOcKdoW+xgBSPlMznjKlcIbGmUVKZu7Cn8ypUAHA9vEsrDm71CFq Ye+4AZwn4VSFV4cjRjo1cwMmkBxsSGgNXpE1HMFdH/5rqDrM/SZaLxcXZYKmSM9Ull TceQ/ilQI39Di5b3y9nIbdABLTAjGY1q3Nz1CRj0l3uy4A8YNwHltbcbLsYffqIrFF cFJHoLigs13GA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A594280357; Tue, 14 May 2024 18:30:48 -0400 (EDT) Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 97AEF120234; Tue, 14 May 2024 18:30:48 -0400 (EDT) In-Reply-To: <87cypomesl.fsf@web.de> (Michael Heerdegen's message of "Tue, 14 May 2024 20:25:30 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285056 Archived-At: >> `prin1` will have its share of downsides, I guess, but when printing >> "arbitrary data", it's definitely a safer choice than `princ` which >> is rarely the right thing (except when printing strings, obviously). > I hope you only mean strings that contain the printed representation of > an object. Our `pp--insert-lisp' prints strings in the argument with > `prin1' (of course). That comment was not specific to `pp--insert-lisp', but much more general. As a general rule of thumb `princ` should be called only with a string as argument (same thing for %s vs %S in `format`). > Thanks for that comment - I updated the patch to use `prin1-char': LGTM, Stefan