From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72616: 30.0.60; M-x apropos-library eglot fails Date: Wed, 14 Aug 2024 07:58:15 -0400 Message-ID: References: <86y14z8o7v.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10733"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 72616@debbugs.gnu.org, Gerard Vermeulen , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 14 13:58:44 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1seCeI-0002Wv-Pc for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Aug 2024 13:58:43 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1seCe6-0006KJ-EW; Wed, 14 Aug 2024 07:58:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1seCe5-0006DK-04 for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2024 07:58:29 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1seCe4-0003av-Ml for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2024 07:58:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=2El1jhlTXtc/Clp94EgomDCgXpHBoZ8fBodfuR+flFY=; b=pT70bWqJ5IUjte10btEZACSfseelqdhOmY7nq+YE6GXoL60xHuwtRs/WAxyrJjqndYMTjFeynPpzGnJcb4MkTiJuwQm+0WQuFkNCuPIrhSEDkSY5DnmxP22p9sh+mlwmrY0+8VlJER9Xt4rEsdN0UJfQCxbU/dNuEajIZQ7G824+lnB0auQUtfUIQMH4V0MZKHhaETfIwbNoxHEkMdSJZUcWeEKoseP+bN+b2q5rXdpwVdhHc67BxIX1V9b/31rcmOhkAcqN62u/sBJ6EO/A2Gk5MpVGQNtVUBRpWGSZKxRZQOlakg7n2SSacoxDZwMkZl5Lt7PaRt6K3tOQvf0Bmg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1seCec-0001ir-8f for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2024 07:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Aug 2024 11:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72616 X-GNU-PR-Package: emacs Original-Received: via spool by 72616-submit@debbugs.gnu.org id=B72616.17236367406611 (code B ref 72616); Wed, 14 Aug 2024 11:59:02 +0000 Original-Received: (at 72616) by debbugs.gnu.org; 14 Aug 2024 11:59:00 +0000 Original-Received: from localhost ([127.0.0.1]:46381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1seCea-0001iZ-6T for submit@debbugs.gnu.org; Wed, 14 Aug 2024 07:59:00 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:30547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1seCeY-0001i9-Jm for 72616@debbugs.gnu.org; Wed, 14 Aug 2024 07:58:59 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2C50A10005D; Wed, 14 Aug 2024 07:58:18 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1723636696; bh=Cmx8js+S7ZqWtmW2vEWZl51vmtpRcdd+8AtXXWNo5PM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=S0gI/lkD8n2U/tpb/xXca4uDj/j2HPiiYN4l89HueDugU8HFOkkgkDaNjViN/5yW3 gTXpHe+J5qu4TPpaVVhLtMCQUtkLVIEqruzSxANjzi8qTEoBe8CCiOTTuBdHvTuwS2 FK6zS9K5Vm8jY9BPqmRmLqLk5mj8VMYzYqjo8NOc8hGlK2ew3BJ7W/m/v0jkTrUpU8 zBTAMwrcciVZ+7FQ6teRq4voewDiwwWcBUYvnePUw8x3ibP2Eq/2Zz3dlmfJA5EPY4 ceyIcpa+rYhI91dMpBCYB+QqSLM1aMG8P9Kz8B2j6/qG3SY+QxhseJuYJE1rQU6IyI EebUQmEfd6TIg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DC4A7100042; Wed, 14 Aug 2024 07:58:16 -0400 (EDT) Original-Received: from pastel (unknown [216.154.9.87]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A77F7120223; Wed, 14 Aug 2024 07:58:16 -0400 (EDT) In-Reply-To: <86y14z8o7v.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 14 Aug 2024 12:09:56 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290133 Archived-At: >> I get the message: >> "apropos-library: Wrong type argument: symbolp, ((cl-deftype-satisfies=20 >> eglot-lsp-server))" >> when I try "M-x apropos-library eglot" > > You forgot to tell that one needs first to load Eglot, otherwise the > above command cannot be invoked at all. > > Stefan and Jo=E3o, is the below the right solution? > > diff --git a/lisp/apropos.el b/lisp/apropos.el > index 6c6cd0b..3fb7581 100644 > --- a/lisp/apropos.el > +++ b/lisp/apropos.el > @@ -731,6 +731,7 @@ apropos-library > ('require (push (cdr x) requires)) > ('provide (push (cdr x) provides)) > ('t nil) ; Skip "was an autoload" entries. > + ('define-symbol-props nil) > ;; FIXME: Print information about each individual method: both > ;; its docstring and specializers (bug#21422). > ('cl-defmethod (push (cadr x) provides)) This doesn't look right: the meaning of `define-symbol-props` in `load-history` should be defined in a more modular way, near `define-symbol-prop` rather than by hardcoding something in `apropos.el`. IOW, we should add something to `apropos.el` where users of `load-history` can register what to do with their entries, just like `find-function-regexp-alist` and the generic function `loadhist-unload-element` are used to tell `find-function` what to do with those same entries. Stefan