url-ldap.el

url-ldap.el

[Luc Teirlinck]

Could somebody familiar with url-ldap.el take a look at the following
compiler warning.   It looks real:

In url-ldap:
url-ldap.el:194:26:Warning: ldap-search-internal called with 7 arguments, but
    accepts only 1
url-ldap.el:193:100:Warning: ldap-search-internal called with 6 arguments, but
    accepts only 1

The function is indeed called twice with many arguments and:

(defun ldap-search-internal (search-plist)

Similar things are going on in sun-fns, but that one is in the
obsolete directory, so maybe it is not worth worrying about:

In mouse-set-mark:
sun-fns.el:88:8:Warning: function mouse-set-mark used to take 1 argument, now
    takes 3

In mouse-select-or-drag-move-point:
sun-fns.el:140:6:Warning: mouse-select-window called with 3 arguments, but
    accepts only 1

In mouse-select-window:
sun-fns.el:286:8:Warning: function mouse-select-window used to take 1
    argument, now takes 3

In mouse-delete-other-windows:
sun-fns.el:290:8:Warning: function mouse-delete-other-windows used to take 0
    arguments, now takes 3

In mouse-delete-window:
sun-fns.el:294:8:Warning: function mouse-delete-window used to take 1
    argument, now takes 3

Sincerely,

Luc.

Re: url-ldap.el

[Richard Stallman]

Don't worry about sun-fns, it is obsolete.

As for url-ldap.el, this is a real problem.  We don't have anyone in
particular who is supposed to work on url.  Please take a look at the
history and see if ldap-search-internal changed its calling
convention; if so, that would give you a step up in fixing the
callers.

Re: url-ldap.el

[Stefan Monnier]

> Don't worry about sun-fns, it is obsolete.
> As for url-ldap.el, this is a real problem.  We don't have anyone in
> particular who is supposed to work on url.  Please take a look at the
> history and see if ldap-search-internal changed its calling
> convention; if so, that would give you a step up in fixing the
> callers.

IIRC Simon Josefsson had a patch for it.


        Stefan

Re: url-ldap.el

[Simon Josefsson]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Don't worry about sun-fns, it is obsolete.
>> As for url-ldap.el, this is a real problem.  We don't have anyone in
>> particular who is supposed to work on url.  Please take a look at the
>> history and see if ldap-search-internal changed its calling
>> convention; if so, that would give you a step up in fixing the
>> callers.
>
> IIRC Simon Josefsson had a patch for it.

Did you mean the TLS stuff?  I did patch url-ldap.el, but I didn't
know how to test it.  I think I asked for testers at the time, but got
no response.  If anyone knows how url-ldap.el is used or how its
functionality can tested, that would be useful.  Alas, I don't have
time to look into url-ldap.el.

Re: url-ldap.el

[Stefan Monnier]

>>> Don't worry about sun-fns, it is obsolete.
>>> As for url-ldap.el, this is a real problem.  We don't have anyone in
>>> particular who is supposed to work on url.  Please take a look at the
>>> history and see if ldap-search-internal changed its calling
>>> convention; if so, that would give you a step up in fixing the
>>> callers.
>> 
>> IIRC Simon Josefsson had a patch for it.

> Did you mean the TLS stuff?  I did patch url-ldap.el, but I didn't
> know how to test it.  I think I asked for testers at the time, but got
> no response.  If anyone knows how url-ldap.el is used or how its
> functionality can tested, that would be useful.  Alas, I don't have
> time to look into url-ldap.el.

Since the current code 100% guaranteed broken, it's probably better to
install your patch.


        Stefan

Re: url-ldap.el

[Simon Josefsson]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>>> Don't worry about sun-fns, it is obsolete.
>>>> As for url-ldap.el, this is a real problem.  We don't have anyone in
>>>> particular who is supposed to work on url.  Please take a look at the
>>>> history and see if ldap-search-internal changed its calling
>>>> convention; if so, that would give you a step up in fixing the
>>>> callers.
>>> 
>>> IIRC Simon Josefsson had a patch for it.
>
>> Did you mean the TLS stuff?  I did patch url-ldap.el, but I didn't
>> know how to test it.  I think I asked for testers at the time, but got
>> no response.  If anyone knows how url-ldap.el is used or how its
>> functionality can tested, that would be useful.  Alas, I don't have
>> time to look into url-ldap.el.
>
> Since the current code 100% guaranteed broken, it's probably better to
> install your patch.

Right.  It was installed some time ago.  It doesn't affect the problem
discussed in this thread, though, I think.

Re: url-ldap.el

[Miles Bader]

On Tue, Nov 16, 2004 at 04:30:50PM -0500, Stefan Monnier wrote:
> Since the current code 100% guaranteed broken, it's probably better to
> install your patch.

Ah, the good old "shoot randomly and listen for a thud" method... :-)

-Miles
-- 
Occam's razor split hairs so well, I bought the whole argument!

Re: url-ldap.el

[CHENG Gao]

ldap-search-internal is not defined in url-ldap.el, but in
lisp/net/ldap.el.

In latest CVS code, the definition of ldap-search-internal is

defun ldap-search-internal (search-plist)

And Google searching generates some useful links for its old definition:

1. http://docsrv.sco.com:8457/cgi-bin/info2html?(lispref.info.gz)Searching%2520on%2520a%2520LDAP%2520Server%2520(Low-level)

the definition is
 - Function: ldap-search-internal ldap filter base scope attrs attrsonly

2. http://www.lns.cornell.edu/public/COMP/info/xemacs/lispref/lispref_54.html
same definition as above.

And from Emacs ediff archive, I found one item committed on Oct. 14,
2003 -
http://lists.gnu.org/archive/html/emacs-diffs/2003-10/msg01232.html, in
which the definition is the same as in latest code. So the change is
before this.

And http://www.tug.org/ftp/texlive/Contents/live/xemtex/lisp/ldap.el is
revision 1.12, in which ldap-search-internal does not exist. And it
makes ldap-search obsolete. Seems it's for Xemacs. I guess around the
time of this revision, Emacs and Xemacs followed different roads.

>From Emacs cvs log, I found the earliest change of ldap-search-internel
is

revision 1.3.4.1
date: 2001/12/28 06:28:32;  author: rms;  state: Exp;  lines: +2 -2
(ldap-search-internal): Handle <file://...> in results.

But there is no record of change to definition.

Wish my observations can be of some use.

-- 
花开花谢春不管，拂意事休对人言
水暖水寒鱼自知，会心处还期独赏

Re: url-ldap.el

[CHENG Gao]

Also I wonder about one thing.

docstring of ldap-search-internal says 

Valid keys in that list are:
host, filter, attributes, attrsonly, base, scope, binddn, passwd, deref,
timelimit, sizelimit, withdn

But in function ldap-search, 

 (setq result (ldap-search-internal (list* 'host host
					      'filter filter
					      'attributes attributes
					      'attrsonly attrsonly
					      'withdn withdn
					      host-plist)))

so base, scope, binddn, passwd, deref, timelimit and sizelimit are
ignored.

My ELISP knowledge is too limited. I dont know if it's right.

-- 
No God blessing me
No Dog barking at me
Gonna adopt a Dog
Name it God
Get blessed and barked at