From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Font slants Date: Sat, 05 Apr 2008 16:30:02 -0400 Message-ID: References: <873aq09x7a.fsf@stupidchicken.com> <873aq0cdan.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1207427429 18045 80.91.229.12 (5 Apr 2008 20:30:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Apr 2008 20:30:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 05 22:31:01 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JiF2N-0000k5-9I for ged-emacs-devel@m.gmane.org; Sat, 05 Apr 2008 22:30:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JiF1k-0007gR-6d for ged-emacs-devel@m.gmane.org; Sat, 05 Apr 2008 16:30:16 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JiF1d-0007cU-PX for emacs-devel@gnu.org; Sat, 05 Apr 2008 16:30:09 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JiF1Y-0007QF-7E for emacs-devel@gnu.org; Sat, 05 Apr 2008 16:30:08 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JiF1Y-0007Py-3w for emacs-devel@gnu.org; Sat, 05 Apr 2008 16:30:04 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182] helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JiF1X-00039i-Vh for emacs-devel@gnu.org; Sat, 05 Apr 2008 16:30:04 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aq0BAGN+90fO+J/WdGdsb2JhbACBXI94ASqYQg X-IronPort-AV: E=Sophos;i="4.25,609,1199682000"; d="scan'208";a="17874889" Original-Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238]) by ironport2-out.teksavvy.com with ESMTP; 05 Apr 2008 16:30:02 -0400 Original-Received: from pastel.home ([206.248.159.214]) by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id LYJ78502; Sat, 05 Apr 2008 16:30:02 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 7F0898898; Sat, 5 Apr 2008 16:30:02 -0400 (EDT) In-Reply-To: <873aq0cdan.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 05 Apr 2008 15:27:44 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:94442 Archived-At: >>> When I do M-x customize-face RET default RET, the value of the `default' >>> face is given as a Lisp expression instead of the usual value menus. >>> This occurs because the slant of the face, as supplied by the new font >>> engine, is "roman". >> >>> I just committed the following patch to fix this. However, I'm not sure >>> these are the only values of the slant parameter. Does anyone know if >>> other possible values could be generated? >> >> Why not use font-slant-table, font-weight-table, and font-swidth-table? > There is one problem with that: font-slant-table etc. are defcustoms, > while custom-face-attributes is a defconst. So if you want to use them > to initialize custom-face-attributes, one possibility is to change > font-slant-table etc into defconsts and move them from faces.el into > cus-face.el. Is it even useful to customize these alists? As long as cus-face is loaded after faces.el, that won't be a serious problem, since it's probably not very useful to customize those lists. I wouldn't have made them customizable, but maybe Handa had good reasons to do that? > On a related note, what's the story behind these settings? > (defcustom font-swidth-table > '((ultracondensed . 50) (ultra-condensed . 51) > ... > Why do we have a practically indistinguishable difference between > ultracondensed and ultra-condensed? Similarly with several other > symbols in these alists. Try to change it (or check vc-annotate) to see why: it needs to be bijective (ie. reversible). Stefan