From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Redesigh of the VC front end Date: Mon, 05 May 2008 21:15:37 -0400 Message-ID: References: <20080506003943.80ED89F054C@snark.thyrsus.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1210036557 22479 80.91.229.12 (6 May 2008 01:15:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 May 2008 01:15:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Eric S. Raymond" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 06 03:16:32 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JtBnA-0002j7-Mq for ged-emacs-devel@m.gmane.org; Tue, 06 May 2008 03:16:28 +0200 Original-Received: from localhost ([127.0.0.1]:49086 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtBmS-0004v7-QD for ged-emacs-devel@m.gmane.org; Mon, 05 May 2008 21:15:44 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JtBmP-0004uN-1F for emacs-devel@gnu.org; Mon, 05 May 2008 21:15:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JtBmM-0004sJ-DD for emacs-devel@gnu.org; Mon, 05 May 2008 21:15:39 -0400 Original-Received: from [199.232.76.173] (port=53351 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtBmM-0004sG-8d for emacs-devel@gnu.org; Mon, 05 May 2008 21:15:38 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JtBmM-0003Yf-Ev for emacs-devel@gnu.org; Mon, 05 May 2008 21:15:38 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAGtOH0hMCqqd/2dsb2JhbACBU6o0 X-IronPort-AV: E=Sophos;i="4.27,440,1204520400"; d="scan'208";a="19956510" Original-Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238]) by ironport2-out.teksavvy.com with ESMTP; 05 May 2008 21:15:37 -0400 Original-Received: from pastel.home ([76.10.170.157]) by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id MGV46037; Mon, 05 May 2008 21:15:37 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 185767FFC; Mon, 5 May 2008 21:15:37 -0400 (EDT) In-Reply-To: <20080506003943.80ED89F054C@snark.thyrsus.com> (Eric S. Raymond's message of "Mon, 5 May 2008 20:39:43 -0400 (EDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:96560 Archived-At: > 2. Otherwise, if you are in a vc dired buffer, and > include-files-not-directories is non-nil, and no fileset is selected, > select all files at and below directory level. This is bad. It should simply return the "file or directory under point". > 2. When the backend supports the concept, every vc-dir buffer has a > special top-line entry that can be marked to select the entire repo. In PCL-CVS we list subdirectories, including ".", which is hence not particularly special. But maybe there's a difference between "." and "the entire repo". > So the Dired code has to go, once the vc-dir code is at functional > parity to it. This will take a little more work. In many respects the vc-dir code will never be at parity with vc-dired, unless we make a special effort to merge it again with dired. I.e. we shouldn't forget that some people liked to do dired operations from vc-dired. For what it's worth, I don't think that merging the two is necessarily a bad idea. But it seems terribly difficult to be able to do such a combined mode that's both as good as dired and as good as vc-dir. > that's what the user selected. This means that file-oriented back ends > (SCCS, RCS, CVS) will have to do directory expansion for themselves > when it is needed. Actually, CVS handles directories just fine in most respects. > There is also a bit of murk around the handling of unregistered files. > I haven't completely thought that one out yet. I think the code can be > rewritten so that filesets of unregistered files are simply passed to > the back end, yielding the VCS's own error for this case when the user > did not select 'register' as the operation. 100% agreement, especially because there may be good reasons for the user to do that (e.g. if Emacs's notion of registration is buggy, or out-of-date, or because the backend includes special semantics for them (e.g. its "commit" operation may automatically add the unregistered files mentioned on the command line). Stefan