From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: vc-revert-hook? Date: Tue, 13 May 2008 10:19:23 -0400 Message-ID: References: <6EE216E1AA959543A555C60FF34FB767040B1D39@maileube01.misys.global.ad> <200805071829.m47ITlkV020399@sallyv1.ics.uci.edu> <6EE216E1AA959543A555C60FF34FB767040F7D64@maileube01.misys.global.ad> <200805081551.m48FpDlm012001@sallyv1.ics.uci.edu> <6EE216E1AA959543A555C60FF34FB76704140371@maileube01.misys.global.ad> <6EE216E1AA959543A555C60FF34FB7670418B0B7@maileube01.misys.global.ad> <6EE216E1AA959543A555C60FF34FB767041E78E4@maileube01.misys.global.ad> <6EE216E1AA959543A555C60FF34FB767041E7E88@maileube01.misys.global.ad> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1210688412 20969 80.91.229.12 (13 May 2008 14:20:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 May 2008 14:20:12 +0000 (UTC) Cc: dann@ics.uci.edu, Andre Spiegel , emacs-devel@gnu.org To: "Marshall\, Simon" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 13 16:20:46 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JvvMo-0006gc-EV for ged-emacs-devel@m.gmane.org; Tue, 13 May 2008 16:20:34 +0200 Original-Received: from localhost ([127.0.0.1]:54209 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JvvM5-0005f9-Di for ged-emacs-devel@m.gmane.org; Tue, 13 May 2008 10:19:49 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JvvM1-0005en-0V for emacs-devel@gnu.org; Tue, 13 May 2008 10:19:45 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JvvLx-0005e1-Mt for emacs-devel@gnu.org; Tue, 13 May 2008 10:19:44 -0400 Original-Received: from [199.232.76.173] (port=38112 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JvvLx-0005dy-Jd for emacs-devel@gnu.org; Tue, 13 May 2008 10:19:41 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:48311) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JvvLt-0004An-Nj; Tue, 13 May 2008 10:19:37 -0400 Original-Received: from ceviche.home (vpn-132-204-232-36.acd.umontreal.ca [132.204.232.36]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id m4DEJoqG031650; Tue, 13 May 2008 10:19:50 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 56F2F70492; Tue, 13 May 2008 10:19:23 -0400 (EDT) In-Reply-To: <6EE216E1AA959543A555C60FF34FB767041E7E88@maileube01.misys.global.ad> (Simon Marshall's message of "Tue, 13 May 2008 10:06:28 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3014=0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97083 Archived-At: >> > Originally, I was suggesting that vc-revert-buffer run the new hook >> > vc-revert-hook, in the same way as vc-next-action runs vc-checkin-hook >> > or vc-checkout-hook. >> >> Sounds OK. Be careful to make it usable for filesets. I.e. it'll >> probably have to be a special hook taking the fileset as argument >> (i.e. you can't call it vc-revert-hook but vc-revert-functions, or >> maybe rather vc-after-revert-functions). > Sorry, I don't follow why it would be any different to vc-checkin-hook > or vc-checkout-hook...? I guess the main difference is that they were introduced long ago. > Or should they also operate on filesets? Yes, Stefan