From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Battery update Date: Fri, 08 Aug 2008 13:56:01 -0400 Message-ID: References: <87bq04dbqc.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1218218209 25046 80.91.229.12 (8 Aug 2008 17:56:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 8 Aug 2008 17:56:49 +0000 (UTC) Cc: 643@emacsbugs.donarmstrong.com, Emre Sahin , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 08 19:57:39 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KRWDL-0006ho-Gf for ged-emacs-devel@m.gmane.org; Fri, 08 Aug 2008 19:57:23 +0200 Original-Received: from localhost ([127.0.0.1]:48813 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KRWCP-000330-U0 for ged-emacs-devel@m.gmane.org; Fri, 08 Aug 2008 13:56:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KRWCM-00031p-92 for emacs-devel@gnu.org; Fri, 08 Aug 2008 13:56:22 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KRWCK-0002xj-05 for emacs-devel@gnu.org; Fri, 08 Aug 2008 13:56:21 -0400 Original-Received: from [199.232.76.173] (port=36447 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KRWCJ-0002xW-Qt for emacs-devel@gnu.org; Fri, 08 Aug 2008 13:56:19 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:50966) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KRWCJ-0006VY-JV for emacs-devel@gnu.org; Fri, 08 Aug 2008 13:56:19 -0400 Original-Received: from ceviche.home (vpn-132-204-232-57.acd.umontreal.ca [132.204.232.57]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id m78HuSej015593; Fri, 8 Aug 2008 13:56:30 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 63975B41C5; Fri, 8 Aug 2008 13:56:01 -0400 (EDT) In-Reply-To: <87bq04dbqc.fsf@stupidchicken.com> (Chong Yidong's message of "Thu, 07 Aug 2008 12:35:39 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3078=0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102215 Archived-At: > Even though it's the feature freeze, I think it's necessary to ensure > that battery.el works at least at a basic level. So, here's a patch Agreed. > ! This function works only with the new `/proc/acpi/' format introduced > ! This function works only with the `/proc/acpi/' format introduced [...] > + This function works only with the new `/sys/class/power_supply/BAT' Given the fix to the docstring for proc-acpi, I think we should try and avoid making the same mistake. I.e. drop the "new". Stefan