From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Kenichi Handa <handa@m17n.org>
Cc: Chong Yidong <cyd@stupidchicken.com>, 2435@emacsbugs.donarmstrong.com
Subject: bug#2435: Bug 2435
Date: Fri, 06 Mar 2009 00:07:48 -0500 [thread overview]
Message-ID: <jwv3adrutp3.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <E1LfRzE-0000uk-Oh@etlken> (Kenichi Handa's message of "Fri, 06 Mar 2009 13:48:40 +0900")
>> > We should take care of re_search_2 and re_match_2_internal
>> > too.
>> >
>> > If the problem is only the call of openp in
>> > load_charset_map_from_file, and building various Lisp object
>> > is ok, we can change load_charset_map_from_file to open a
>> > charset map by itself without using openp.
>> Not using openp would be troublesome. How about binding
>> file-name-handler-alist to nil inside load_charset_map_from_file? That
>> prevents find-file-name-handler from performing the regexp compilation
>> and string search.
> That's a good idea if "building various Lisp object is ok"
> is true.
AFAIK building objects is perfectly fine, yes.
I wonder why you use record_unwind_protect rather than specbind, tho.
Also if we do that, we should add a note in the docstring of
charset-map-path that it does not obey file-name-handler-alist.
Stefan
next prev parent reply other threads:[~2009-03-06 5:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87fxhvcmvf.fsf@cyd.mit.edu>
[not found] ` <E1LePPk-0002zE-RW@etlken>
2009-03-03 16:40 ` bug#2435: Bug 2435 Chong Yidong
2009-03-04 2:16 ` Kenichi Handa
2009-03-04 4:41 ` Chong Yidong
2009-03-04 7:47 ` Kenichi Handa
2009-03-05 4:09 ` Chong Yidong
2009-03-05 6:39 ` Kenichi Handa
2009-03-05 4:42 ` Chong Yidong
2009-03-05 11:23 ` Kenichi Handa
2009-03-05 16:46 ` Stefan Monnier
2009-03-06 3:38 ` Kenichi Handa
2009-03-06 4:11 ` Chong Yidong
2009-03-06 4:48 ` Kenichi Handa
2009-03-06 5:07 ` Stefan Monnier [this message]
2009-03-06 5:21 ` Kenichi Handa
2009-03-07 4:00 ` Chong Yidong
2009-03-07 23:07 ` Stefan Monnier
2009-03-09 1:12 ` Kenichi Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv3adrutp3.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=2435@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
--cc=handa@m17n.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.