all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: rms@gnu.org
Cc: emacs-pretest-bug@gnu.org, 2445@emacsbugs.donarmstrong.com
Subject: bug#2445: 23.0.90; file name completion GCs a lot
Date: Thu, 19 Mar 2009 16:43:14 -0400	[thread overview]
Message-ID: <jwv3ad91c0m.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <E1LkO32-0004Ia-90@fencepost.gnu.org> (Richard M. Stallman's message of "Thu, 19 Mar 2009 15:37:00 -0400")

>     Can you try the patch below to confirm it fixes your problem?
> The problem in my real cases is fixed given the sources as of
> yesterday.  It looks like you've identified fixes to other big
> slowdowns that arise in yet larger test cases.  I don't need them,
> but now that you've written them, you may as well install them
> unless they will cause trouble for someone.

Sorry about the email confusion: I wrote and sent the second email
first, but it got stuck on its machine and only got delivered much
later, at which point I had written the second email and installed the
fix already.

>     In the case of file completion, a simple (file-directory-p "xmail/")
>     would give us the necessary answer, but the code is generic and the
>     only/best way to get this information from a completion tables is to
>     call (try-completion "xmail/" table), which calls (file-name-completion
>     "" "xmail/").

> I have a feeling that (file-name-completion "" "xmail/") ought to
> first check (file-directory-p "xmail/") and return t if that does.

No: if all files in xmail/ start with "aba", then the above should
return "aba".


        Stefan






  reply	other threads:[~2009-03-19 20:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-23 15:02 bug#2445: 23.0.90; file name completion GCs a lot Richard M Stallman
2009-02-25 16:35 ` Stefan Monnier
2009-02-26 19:25   ` Richard M Stallman
2009-03-17 18:03 ` Stefan Monnier
2009-03-19 19:37   ` Richard M Stallman
2009-03-19 20:43     ` Stefan Monnier [this message]
2009-03-20 22:52       ` Richard M Stallman
2009-03-21  1:41         ` Stefan Monnier
2009-03-18 13:40 ` Stefan Monnier
2009-03-18 22:18   ` Richard M Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv3ad91c0m.fsf-monnier+emacsbugreports@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=2445@emacsbugs.donarmstrong.com \
    --cc=emacs-pretest-bug@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.