From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Juri Linkov <juri@jurta.org>
Cc: 4896@emacsbugs.donarmstrong.com, Tassilo Horn <tassilo@member.fsf.org>
Subject: bug#4896: DocView: Continuous mode
Date: Tue, 24 Nov 2009 14:48:36 -0500 [thread overview]
Message-ID: <jwv3a43k8r5.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <877htgyrwy.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 24 Nov 2009 19:08:09 +0200")
> Any ideas how to specify doc-view scrolling functions for mwheel.el
> in doc-view continuous mode?
mwheel could introduce mwheel-scroll-up-function and
mwheel-scroll-up-function (with global defaults of scroll-up and
scroll-down, obviously) which doc-view could set buffer-locally.
Or we could rename scroll-up/down to scroll-up/down-internal and let
scroll-up/down obey new scroll-up/down-function hooks.
I guess starting with mwheel-scroll-up/down-function is less invasive.
Stefan
> Index: lisp/mwheel.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/mwheel.el,v
> retrieving revision 1.56
> diff -u -r1.56 mwheel.el
> --- lisp/mwheel.el 12 Sep 2009 19:03:52 -0000 1.56
> +++ lisp/mwheel.el 24 Nov 2009 17:07:28 -0000
> @@ -206,7 +206,10 @@
> (unwind-protect
> (let ((button (mwheel-event-button event)))
> (cond ((eq button mouse-wheel-down-event)
> - (condition-case nil (scroll-down amt)
> + (condition-case nil
> + (if (eq major-mode 'doc-view-mode)
> + (doc-view-scroll-down-or-previous-page amt)
> + (scroll-down amt))
> ;; Make sure we do indeed scroll to the beginning of
> ;; the buffer.
> (beginning-of-buffer
> @@ -221,7 +224,10 @@
> ;; to only affect scroll-down. --Stef
> (set-window-start (selected-window) (point-min))))))
> ((eq button mouse-wheel-up-event)
> - (condition-case nil (scroll-up amt)
> + (condition-case nil
> + (if (eq major-mode 'doc-view-mode)
> + (doc-view-scroll-up-or-next-page amt)
> + (scroll-up amt))
> ;; Make sure we do indeed scroll to the end of the buffer.
> (end-of-buffer (while t (scroll-up)))))
> (t (error "Bad binding in mwheel-scroll"))))
> Index: lisp/doc-view.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/doc-view.el,v
> retrieving revision 1.90
> diff -u -r1.90 doc-view.el
> --- lisp/doc-view.el 24 Nov 2009 07:47:49 -0000 1.90
> +++ lisp/doc-view.el 24 Nov 2009 17:07:00 -0000
> @@ -431,24 +431,24 @@
> (interactive)
> (doc-view-goto-page (length doc-view-current-files)))
> -(defun doc-view-scroll-up-or-next-page ()
> +(defun doc-view-scroll-up-or-next-page (&optional n)
> "Scroll page up if possible, else goto next page."
> - (interactive)
> + (interactive "^P")
> (let ((hscroll (window-hscroll))
> (cur-page (doc-view-current-page)))
> - (when (= (window-vscroll) (image-scroll-up nil))
> + (when (= (window-vscroll) (image-scroll-up n))
> (doc-view-next-page)
> (when (/= cur-page (doc-view-current-page))
> (image-bob)
> (image-bol 1))
> (set-window-hscroll (selected-window) hscroll))))
> -(defun doc-view-scroll-down-or-previous-page ()
> +(defun doc-view-scroll-down-or-previous-page (&optional n)
> "Scroll page down if possible, else goto previous page."
> - (interactive)
> + (interactive "^P")
> (let ((hscroll (window-hscroll))
> (cur-page (doc-view-current-page)))
> - (when (= (window-vscroll) (image-scroll-down nil))
> + (when (= (window-vscroll) (image-scroll-down n))
> (doc-view-previous-page)
> (when (/= cur-page (doc-view-current-page))
> (image-eob)
> --
> Juri Linkov
> http://www.jurta.org/emacs/
next prev parent reply other threads:[~2009-11-24 19:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 7:45 bug#4896: DocView: Continuous mode Juri Linkov
2009-11-10 18:03 ` Stefan Monnier
2009-11-12 9:57 ` Juri Linkov
2009-11-12 11:04 ` Tassilo Horn
2009-11-12 11:14 ` Juri Linkov
2009-11-12 13:10 ` Tassilo Horn
2009-11-12 15:49 ` Stefan Monnier
2009-11-12 16:01 ` Tassilo Horn
2009-11-23 9:47 ` Juri Linkov
2009-11-23 11:07 ` Tassilo Horn
2009-11-23 20:43 ` Juri Linkov
2009-11-24 17:08 ` Juri Linkov
2009-11-24 19:48 ` Stefan Monnier [this message]
2009-11-25 17:28 ` Juri Linkov
2009-11-28 22:52 ` Juri Linkov
[not found] ` <mailman.11748.1259452054.2239.bug-gnu-emacs@gnu.org>
2009-11-29 9:27 ` Tassilo Horn
2009-11-29 16:05 ` Juri Linkov
2009-11-29 19:11 ` Tassilo Horn
2009-11-29 22:05 ` Juri Linkov
2009-11-30 7:32 ` Tassilo Horn
2009-11-30 12:04 ` Juri Linkov
2009-11-30 13:36 ` Tassilo Horn
2009-11-30 16:17 ` Juri Linkov
2009-11-24 17:06 ` Juri Linkov
2009-11-23 9:52 ` Juri Linkov
2009-11-23 11:03 ` Tassilo Horn
2009-11-23 21:36 ` Stefan Monnier
2009-11-24 17:06 ` Juri Linkov
2009-12-16 9:23 ` Juri Linkov
2010-02-01 23:30 ` bug#4896: Doc-view-mode with View-mode Juri Linkov
2010-02-02 2:45 ` Stefan Monnier
2010-02-02 22:49 ` Juri Linkov
2010-02-03 2:36 ` Stefan Monnier
2010-02-04 0:01 ` Juri Linkov
2010-02-04 15:43 ` Stefan Monnier
2010-02-04 19:45 ` Juri Linkov
2010-02-04 22:35 ` Stefan Monnier
2022-04-28 12:08 ` bug#4896: DocView: Continuous mode Lars Ingebrigtsen
2022-04-28 17:35 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv3a43k8r5.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=4896@emacsbugs.donarmstrong.com \
--cc=juri@jurta.org \
--cc=tassilo@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.