all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Štěpán Němec" <stepnem@gmail.com>
Cc: joakim@verona.se, Emacs developers <emacs-devel@gnu.org>
Subject: Re: calc-undo keybinding
Date: Thu, 20 Jan 2011 10:53:22 -0500	[thread overview]
Message-ID: <jwv39onwp32.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87pqrryjmf.fsf@gmail.com> ("Štěpán Němec"'s message of "Thu, 20 Jan 2011 11:06:32 +0100")

>> --- lisp/calc/calc-ext.el	2011-01-16 02:21:30 +0000
>> +++ lisp/calc/calc-ext.el	2011-01-19 23:12:20 +0000
>> @@ -136,8 +136,7 @@
>> (define-key calc-mode-map "\C-w" 'calc-kill-region)
>> (define-key calc-mode-map "\M-w" 'calc-copy-region-as-kill)
>> (define-key calc-mode-map "\M-\C-w" 'kill-ring-save)
>> -  (define-key calc-mode-map "\C-_" 'calc-undo)
>> -  (define-key calc-mode-map "\C-xu" 'calc-undo)
>> +  (substitute-key-definition 'undo 'calc-undo calc-mode-map global-map)
>> (define-key calc-mode-map "\M-\C-m" 'calc-last-args)
>> 
>> (define-key calc-mode-map "a" nil)

> Why not just use command remapping, i.e.

>   (define-key calc-mode-map [remap undo] 'calc-undo)

> ? (It won't work on XEmacs AFAIK, but that's not a problem for you I'm
> guessing.)

That's an alternative, yes.  Not knowing enough about how what calc-undo
does, I can't judge whether that's preferable (which mostly depends on
whether it's OK to render the real `undo' completely unreachable (other
than via M-x undo) in those buffers).  I'll let the Calc maintainer
figure that one out.


        Stefan



  reply	other threads:[~2011-01-20 15:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19 15:58 calc-undo keybinding joakim
2011-01-19 20:58 ` Stefan Monnier
2011-01-19 21:48   ` joakim
2011-01-19 23:13     ` Stefan Monnier
2011-01-20 10:06       ` Štěpán Němec
2011-01-20 15:53         ` Stefan Monnier [this message]
2011-01-20 18:57           ` Jay Belanger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv39onwp32.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=joakim@verona.se \
    --cc=stepnem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.