From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#7952: 24.0.50; crash in find_interval Date: Sat, 30 Apr 2011 10:16:44 -0300 Message-ID: References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> <834o5g7wi7.fsf@gnu.org> <87wric23iq.fsf@silenus.orebokech.com> <83sjt05d5i.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1304170627 15084 80.91.229.12 (30 Apr 2011 13:37:07 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 30 Apr 2011 13:37:07 +0000 (UTC) Cc: cyd@stupidchicken.com, Romain Francoise , 7952@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 30 15:37:03 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QGAM1-0002pe-9t for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Apr 2011 15:37:01 +0200 Original-Received: from localhost ([::1]:53575 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QGAM0-0007F8-KF for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Apr 2011 09:37:00 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:47087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QGALw-0007AR-QA for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2011 09:36:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QGALv-0000xi-TT for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2011 09:36:56 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QGALv-0000xc-PH for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2011 09:36:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QGA2g-0001n0-4q; Sat, 30 Apr 2011 09:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Apr 2011 13:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7952 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7952-submit@debbugs.gnu.org id=B7952.13041694176864 (code B ref 7952); Sat, 30 Apr 2011 13:17:02 +0000 Original-Received: (at 7952) by debbugs.gnu.org; 30 Apr 2011 13:16:57 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QGA2Z-0001mf-Ko for submit@debbugs.gnu.org; Sat, 30 Apr 2011 09:16:56 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QGA2X-0001mS-BI for 7952@debbugs.gnu.org; Sat, 30 Apr 2011 09:16:54 -0400 Original-Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:37275 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QGA2R-0007uT-84; Sat, 30 Apr 2011 09:16:47 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 951DB660D4; Sat, 30 Apr 2011 10:16:44 -0300 (ART) In-Reply-To: <83sjt05d5i.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Apr 2011 11:58:17 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 30 Apr 2011 09:17:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:46098 Archived-At: >> Not sure if it's related, but using grep results in lots of those in >> the Messages buffer: >> >> | Error during redisplay: (args-out-of-range 26100 26140) >> | Error during redisplay: (args-out-of-range 55792 55803) >> | Error during redisplay: (args-out-of-range 89118 89155) >> | Error during redisplay: (args-out-of-range 107767 107804) >> | Error during redisplay: (args-out-of-range 119160 119176) >> | Error during redisplay: (args-out-of-range 152422 152434) > It's unrelated to the crash, but it's caused by the same reason: > jit-lock's function jit-lock-fontify-now also assumes that buffer > positions don't change as result of fontification. The patch below, > which uses markers for those positions that can change, seems to fix > that. > Before I commit this, I'd appreciate a review by Stefan (and anyone > else who cares to comment), especially wrt to semi-kludgey updating of > jit-lock-context-unfontify-pos (I wasn't sure making it a marker would > be TRT). As can be seen by a comment in grep.el, I consider grep's updating of the buffer as a problem. Also, we've seen other reasons why grep's handling of escape sequences should be performed in the process filter rather than in font-lock. So I'd rather say that grep's use of font-lock is wrong, rather than change jit-lock to accommodate it. Your earlier fix that eliminates the crash is not affected by this decision, because even bad Lisp code should not be able to crash Emacs so easily, so even if it's triggered by grep.el's bad code, it still needs to be fixed. Stefan