all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: cyd@stupidchicken.com, Romain Francoise <romain@orebokech.com>,
	7952@debbugs.gnu.org
Subject: bug#7952: 24.0.50; crash in find_interval
Date: Sat, 30 Apr 2011 10:16:44 -0300	[thread overview]
Message-ID: <jwv39kzhofz.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83sjt05d5i.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Apr 2011 11:58:17 +0300")

>> Not sure if it's related, but using grep results in lots of those in
>> the Messages buffer:
>> 
>> | Error during redisplay: (args-out-of-range 26100 26140)
>> | Error during redisplay: (args-out-of-range 55792 55803)
>> | Error during redisplay: (args-out-of-range 89118 89155)
>> | Error during redisplay: (args-out-of-range 107767 107804)
>> | Error during redisplay: (args-out-of-range 119160 119176)
>> | Error during redisplay: (args-out-of-range 152422 152434)

> It's unrelated to the crash, but it's caused by the same reason:
> jit-lock's function jit-lock-fontify-now also assumes that buffer
> positions don't change as result of fontification.  The patch below,
> which uses markers for those positions that can change, seems to fix
> that.

> Before I commit this, I'd appreciate a review by Stefan (and anyone
> else who cares to comment), especially wrt to semi-kludgey updating of
> jit-lock-context-unfontify-pos (I wasn't sure making it a marker would
> be TRT).

As can be seen by a comment in grep.el, I consider grep's updating of
the buffer as a problem.  Also, we've seen other reasons why grep's
handling of escape sequences should be performed in the process filter
rather than in font-lock.  So I'd rather say that grep's use of
font-lock is wrong, rather than change jit-lock to accommodate it.

Your earlier fix that eliminates the crash is not affected by this
decision, because even bad Lisp code should not be able to crash Emacs
so easily, so even if it's triggered by grep.el's bad code, it still
needs to be fixed.


        Stefan





  reply	other threads:[~2011-04-30 13:16 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.0.1296565545.10637.bug-gnu-emacs@gnu.org>
2011-03-09 12:25 ` bug#7952: 24.0.50; crash in find_interval Romain Francoise
2011-03-09 13:46   ` Eli Zaretskii
2011-03-09 15:16     ` Romain Francoise
2011-03-18 19:19   ` Romain Francoise
2011-03-18 19:37     ` Eli Zaretskii
2011-03-18 20:45       ` Romain Francoise
2011-03-19 10:37         ` Eli Zaretskii
2011-03-19 12:14           ` Andreas Schwab
2011-03-19 12:51             ` Eli Zaretskii
2011-03-19 13:18               ` Andreas Schwab
2011-03-19 13:56             ` Romain Francoise
2011-04-13 21:06         ` Chong Yidong
2011-04-14  4:36           ` Eli Zaretskii
2011-04-14 13:18             ` Romain Francoise
2011-04-26  8:39             ` Romain Francoise
2011-04-26 17:52               ` Eli Zaretskii
2011-04-29 18:17                 ` Eli Zaretskii
2011-04-29 20:42                   ` Romain Francoise
2011-04-30  8:58                     ` Eli Zaretskii
2011-04-30 13:16                       ` Stefan Monnier [this message]
2011-04-30 13:24                         ` Eli Zaretskii
2011-05-02 14:51                           ` Stefan Monnier
2011-05-08  5:18                         ` Chong Yidong
2011-05-08 15:28                           ` Eli Zaretskii
2011-05-08 20:27                             ` Chong Yidong
2011-05-09  6:24                               ` Eli Zaretskii
2011-05-09 14:06                                 ` Stefan Monnier
2011-05-09 14:46                                   ` Eli Zaretskii
2011-05-09 15:32                                     ` Stefan Monnier
2011-05-09 15:42                                       ` Eli Zaretskii
2011-05-09 17:09                                         ` Stefan Monnier
2011-05-09 19:46                                 ` Chong Yidong
2011-05-09 20:31                                   ` Eli Zaretskii
2011-02-01 12:41 Romain Francoise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv39kzhofz.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=7952@debbugs.gnu.org \
    --cc=cyd@stupidchicken.com \
    --cc=eliz@gnu.org \
    --cc=romain@orebokech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.