From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 11348@debbugs.gnu.org
Subject: bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows
Date: Mon, 07 May 2012 11:27:15 -0400 [thread overview]
Message-ID: <jwv397cuicj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83fwbf5e8v.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 May 2012 09:33:04 +0300")
> I'm not sure why it worked for you, because it still doesn't for me.
> Are you applying the changes to the emacs-24 branch? Because that's
> what I do, this bug being against Emacs 24.0.96 and a regression from
> Emacs 23.4.
Yes, I tried it with the 24.0.96 pretest. Hmm...
> According to my debugging inside shell-parse-pcomplete-arguments, what
> happens there is that this fragment
> (while (looking-at
> (eval-when-compile
> (concat
> "\\(?:[^\s\t\n\\\"']+"
> "\\|'\\([^']*\\)'?"
> "\\|\"\\(\\(?:[^\"\\]\\|\\\\.\\)*\\)\"?"
> "\\|\\\\\\(\\(?:.\\|\n\\)?\\)\\)")))
> decides that \g is an escape sequence.
No, it does match "\g" but then the new code:
(push (cond
((null pcomplete-arg-quote-list)
(goto-char (match-beginning 3)) "\\")
((= (match-beginning 3) (match-end 3)) "\\")
(t (match-string 3)))
arg))
sees that pcomplete-arg-quote-list is nil, pushes "\\" and moves
backward 1 char (to right before the "g") so you end up with
("gnu" "\\" "d:").
Can you check to see why this is not happening?
> (Btw, what's the purpose of using eval-when-compile here?)
To avoid calling `concat' at run-time (especially within the loop).
In older Emacsen, `concat' was marked as pure so the byte-compiler would
evaluate it at compile-time, but someone complained that it's not
strictly correct because he wanted that (concat <foo>) is not `eq' to
(concat <foo>). I actually think this change was a mistake and would
rather mark `concat' as pure again.
Stefan
next prev parent reply other threads:[~2012-05-07 15:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 11:09 bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows Eli Zaretskii
2012-05-04 7:10 ` Eli Zaretskii
2012-05-04 14:29 ` Chong Yidong
2012-05-04 14:54 ` Eli Zaretskii
2012-05-04 15:07 ` Drew Adams
2012-05-04 15:36 ` Chong Yidong
2012-05-04 15:02 ` Eli Zaretskii
2012-05-04 15:46 ` Chong Yidong
2012-05-04 17:01 ` Eli Zaretskii
2012-05-04 17:59 ` Stefan Monnier
2012-05-04 18:15 ` Eli Zaretskii
2012-05-04 23:32 ` Stefan Monnier
2012-05-05 0:22 ` Drew Adams
2012-05-05 12:47 ` Eli Zaretskii
2012-05-05 4:20 ` Stefan Monnier
2012-05-05 6:33 ` Eli Zaretskii
2012-05-07 8:01 ` Chong Yidong
2012-05-07 17:40 ` Eli Zaretskii
2012-05-07 15:27 ` Stefan Monnier [this message]
2012-05-07 15:44 ` Drew Adams
2012-05-07 16:11 ` Chong Yidong
2012-05-08 0:27 ` Stefan Monnier
2012-05-08 18:56 ` Eli Zaretskii
2012-05-09 17:22 ` Stefan Monnier
2012-05-09 18:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv397cuicj.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=11348@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.