From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#11506: bug: "C-x z" ("repeat") no longer works correctly with M-x Date: Sat, 02 Jun 2012 15:21:51 -0400 Message-ID: References: <87396ylx5m.fsf@catnip.gol.com> <87pq9ndq0n.fsf@gnu.org> <8762ba8b6p.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1338665040 15482 80.91.229.3 (2 Jun 2012 19:24:00 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 2 Jun 2012 19:24:00 +0000 (UTC) Cc: 11506-done@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 02 21:23:57 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Satu2-0007j4-NH for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jun 2012 21:22:22 +0200 Original-Received: from localhost ([::1]:44589 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Satu2-0005WH-8t for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jun 2012 15:22:22 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sattx-0005VL-Ez for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2012 15:22:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sattv-0007dX-Qt for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2012 15:22:17 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sattv-0007dB-N7 for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2012 15:22:15 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Satve-0002x6-HO for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2012 15:24:02 -0400 Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Jun 2012 19:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 11506 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 11506@debbugs.gnu.org, monnier@iro.umontreal.ca Original-Received: via spool by 11506-done@debbugs.gnu.org id=D11506.133866502711323 (code D ref 11506); Sat, 02 Jun 2012 19:24:02 +0000 Original-Received: (at 11506-done) by debbugs.gnu.org; 2 Jun 2012 19:23:47 +0000 Original-Received: from localhost ([127.0.0.1]:54899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SatvP-0002wZ-79 for submit@debbugs.gnu.org; Sat, 02 Jun 2012 15:23:47 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:27189) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SatvN-0002wM-4b for 11506-done@debbugs.gnu.org; Sat, 02 Jun 2012 15:23:45 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09sr+UI/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLDiYSFBgNJIgcBboJkEQDozOBWIMF X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="187049938" Original-Received: from 108-175-229-8.dsl.teksavvy.com (HELO pastel.home) ([108.175.229.8]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 02 Jun 2012 15:21:51 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 8C5B859607; Sat, 2 Jun 2012 15:21:51 -0400 (EDT) In-Reply-To: <8762ba8b6p.fsf@gnu.org> (Chong Yidong's message of "Sat, 02 Jun 2012 14:44:46 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60634 Archived-At: > The problem is that the old execute-extended-command sets the > real_this_command internal variable, which causes the Emacs command loop > to record the command that was actually executed into real-last-command > and last-repeatable-command. Indeed. > In other words, it's not just the fact that `C-x z' doesn't work > properly. Moving execute-extended-command to Lisp produces a > backward-incompatible change in the values of the real-last-command and > last-repeatable-command variables for M-x. I suspect this may break > things other than `C-x z'. I guess we could fix this by exposing > real_this_command to Lisp too, but that kinda defeats the point of that > variable... I don't see why this would defeat anything. Clearly, execute-extended-command demonstrates that there can be very good reasons to change real-this-command. I installed a change that does just that. > Is there a strong rationale for moving execute-extended-command to Lisp, > other than the general principle that we want as much functionality > implemented Lisp as possible? To me, an important part of moving code to Elisp is to make sure that it *can* be implemented in Elisp (i.e. that some third-party package can provide a new implementation of that functionality). Stefan