From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Glenn Morris <rgm@gnu.org>
Cc: Richard Copley <rcopley@gmail.com>, 11780@debbugs.gnu.org
Subject: bug#11780: 24.1.50; vc-annotate fails for files in RCS. ("cl.el" `flet' problem?)
Date: Tue, 26 Jun 2012 20:56:01 -0400 [thread overview]
Message-ID: <jwv395h8trr.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <nb395hn1ao.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 26 Jun 2012 18:41:51 -0400")
> So there's a couple of things wrong with the new version:
> `x' used twice as a local variable.
That's an illusion: these are two different uninterned symbols (of the
same name).
> (symbol-function 'sw) not guarded by an (fboundp 'sw) check.
Indeed.
> The latter is the immediate source of the error AFAICS.
Does the patch below fix things?
Stefan
=== modified file 'lisp/vc/vc-rcs.el'
--- lisp/vc/vc-rcs.el 2012-06-06 01:28:08 +0000
+++ lisp/vc/vc-rcs.el 2012-06-27 00:52:54 +0000
@@ -679,7 +679,7 @@
;; Apply reverse-chronological edits on the trunk, computing and
;; accumulating forward-chronological edits after some point, for
;; later.
- (flet ((r/d/a () (vector pre
+ (cl-flet ((r/d/a () (vector pre
(cdr (assq 'date meta))
(cdr (assq 'author meta)))))
(while (when (setq pre cur cur (cdr (assq 'next meta)))
next prev parent reply other threads:[~2012-06-27 0:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 17:24 bug#11780: 24.1.50; vc-annotate fails for files in RCS. ("cl.el" `flet' problem?) Richard Copley
2012-06-25 18:48 ` Eli Zaretskii
2012-06-25 19:03 ` Richard Copley
2012-06-26 22:41 ` Glenn Morris
2012-06-27 0:56 ` Stefan Monnier [this message]
2012-06-27 1:13 ` Glenn Morris
2012-06-27 14:26 ` Stefan Monnier
2012-06-27 23:14 ` Glenn Morris
2012-06-28 0:31 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv395h8trr.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=11780@debbugs.gnu.org \
--cc=rcopley@gmail.com \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.