From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Inefficiency in Bgotoifnil byte-code instruction Date: Tue, 10 Jul 2012 06:31:09 -0400 Message-ID: References: <87k3yq2htz.fsf@fleche.redhat.com> <87y5n2vupa.fsf@fleche.redhat.com> <87wr2kvr6g.fsf@fleche.redhat.com> <87ipe4vjy1.fsf@fleche.redhat.com> <87k3yckaur.fsf@fleche.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1341916292 24800 80.91.229.3 (10 Jul 2012 10:31:32 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 10 Jul 2012 10:31:32 +0000 (UTC) Cc: Mohamed Ben-Ahssene , emacs-devel@gnu.org To: Tom Tromey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 10 12:31:31 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SoXj7-0003dJ-PL for ged-emacs-devel@m.gmane.org; Tue, 10 Jul 2012 12:31:29 +0200 Original-Received: from localhost ([::1]:50795 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoXj6-0006KJ-Qo for ged-emacs-devel@m.gmane.org; Tue, 10 Jul 2012 06:31:28 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoXiz-0006J6-Bw for emacs-devel@gnu.org; Tue, 10 Jul 2012 06:31:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SoXit-0007jR-84 for emacs-devel@gnu.org; Tue, 10 Jul 2012 06:31:20 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:52675) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoXit-0007jD-4Q for emacs-devel@gnu.org; Tue, 10 Jul 2012 06:31:15 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q6AAV9nx012962; Tue, 10 Jul 2012 06:31:10 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 3720CAECB7; Tue, 10 Jul 2012 06:31:09 -0400 (EDT) In-Reply-To: <87k3yckaur.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon, 09 Jul 2012 13:12:12 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4274=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4274> : streams <782058> : uri <1161468> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151512 Archived-At: > How do you feel about this ChangeLog entry? Looks OK. Nit picks: > + * bytecode.c (BYTE_CODE_THREADED): New define. We usually call cpp definitions "macros" rather than "defines". Also, add a line saying something like "Use indirect threading when applicable". > + (BYTE_CODES): New define. Replaces all old byte-code defines. > + (enum byte_code_op): New. This one is a new *type*. > + (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New defines. > + (exec_byte_code): Use new defines. And this last one can just be "Use them". > I wasn't sure if you wanted me to spell out all the Bmumble defines that > were replaced. No, that's not necessary. Stefan