From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Tom Tromey <tromey@redhat.com>
Cc: Mohamed Ben-Ahssene <benahssm@IRO.UMontreal.CA>, emacs-devel@gnu.org
Subject: Re: Inefficiency in Bgotoifnil byte-code instruction
Date: Tue, 10 Jul 2012 06:31:09 -0400 [thread overview]
Message-ID: <jwv394zvrjf.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87k3yckaur.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon, 09 Jul 2012 13:12:12 -0600")
> How do you feel about this ChangeLog entry?
Looks OK. Nit picks:
> + * bytecode.c (BYTE_CODE_THREADED): New define.
We usually call cpp definitions "macros" rather than "defines".
Also, add a line saying something like "Use indirect threading when
applicable".
> + (BYTE_CODES): New define. Replaces all old byte-code defines.
> + (enum byte_code_op): New.
This one is a new *type*.
> + (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New defines.
> + (exec_byte_code): Use new defines.
And this last one can just be "Use them".
> I wasn't sure if you wanted me to spell out all the Bmumble defines that
> were replaced.
No, that's not necessary.
Stefan
next prev parent reply other threads:[~2012-07-10 10:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 3:01 Inefficiency in Bgotoifnil byte-code instruction John Wiegley
2012-06-28 4:38 ` Stefan Monnier
2012-06-29 16:39 ` Tom Tromey
2012-06-30 4:07 ` Stefan Monnier
2012-07-02 19:17 ` Tom Tromey
2012-07-03 13:19 ` Stefan Monnier
2012-07-03 14:45 ` Tom Tromey
2012-07-03 16:58 ` Stefan Monnier
2012-07-03 17:22 ` Tom Tromey
2012-07-03 17:53 ` Aurélien Aptel
2012-07-03 19:24 ` Tom Tromey
2012-07-03 23:02 ` Stefan Monnier
2012-07-06 20:22 ` Tom Tromey
2012-07-06 21:39 ` Stefan Monnier
2012-07-09 19:12 ` Tom Tromey
2012-07-10 10:31 ` Stefan Monnier [this message]
2012-07-03 19:52 ` John Wiegley
2012-07-06 20:27 ` Tom Tromey
2012-07-02 3:51 ` John Wiegley
2012-07-02 14:08 ` Tom Tromey
2012-06-28 4:41 ` Stefan Monnier
2012-06-28 13:07 ` Richard Stallman
2012-06-28 21:24 ` John Wiegley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv394zvrjf.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=benahssm@IRO.UMontreal.CA \
--cc=emacs-devel@gnu.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.