From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#12597: 24.2.50; Cannot exit read-passwd by C-j/C-m/ Date: Sun, 07 Oct 2012 15:34:55 -0400 Message-ID: References: <87fw5q2p9e.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1349638566 21597 80.91.229.3 (7 Oct 2012 19:36:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 7 Oct 2012 19:36:06 +0000 (UTC) Cc: 12597-done@debbugs.gnu.org To: Takafumi Arakaki Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 07 21:36:12 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TKwe1-0006Z9-2b for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Oct 2012 21:36:09 +0200 Original-Received: from localhost ([::1]:34915 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKwdv-0008NJ-3V for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Oct 2012 15:36:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKwdZ-0007WM-16 for bug-gnu-emacs@gnu.org; Sun, 07 Oct 2012 15:35:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TKwdX-0005cZ-M2 for bug-gnu-emacs@gnu.org; Sun, 07 Oct 2012 15:35:40 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKwdX-0005cQ-IO for bug-gnu-emacs@gnu.org; Sun, 07 Oct 2012 15:35:39 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TKwdu-0003sK-Jz for bug-gnu-emacs@gnu.org; Sun, 07 Oct 2012 15:36:02 -0400 Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Oct 2012 19:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 12597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 12597@debbugs.gnu.org, monnier@IRO.UMontreal.CA Original-Received: via spool by 12597-done@debbugs.gnu.org id=D12597.134963852814854 (code D ref 12597); Sun, 07 Oct 2012 19:36:02 +0000 Original-Received: (at 12597-done) by debbugs.gnu.org; 7 Oct 2012 19:35:28 +0000 Original-Received: from localhost ([127.0.0.1]:60346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKwdM-0003rX-7m for submit@debbugs.gnu.org; Sun, 07 Oct 2012 15:35:28 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:39727) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKwdI-0003rL-3B for 12597-done@debbugs.gnu.org; Sun, 07 Oct 2012 15:35:26 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q97JYvJh032652; Sun, 7 Oct 2012 15:34:59 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id D67F6AE3A5; Sun, 7 Oct 2012 15:34:55 -0400 (EDT) In-Reply-To: <87fw5q2p9e.fsf@gmail.com> (Takafumi Arakaki's message of "Sun, 07 Oct 2012 18:58:05 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65354 Archived-At: > Type M-: (read-passwd "> ") RET > then you cannot finish the prompt by C-j nor C-m nor . > The only when I found is C-M-c (exit-recursive-edit). This > effects for example when typing password to send email using smtpmail. > This is strange because minibuffer-local-map (parent of read-passwd-map) > defines exit-minibuffer. Thanks for the heads up. Indeed, it got me stumped for a while until I realized that defconst behaves funny during the dump (it purecopy's its argument, so we get a snapshot of minibuffer-local-map, taken before minibuffer-local-map has been populated). I installed the patch below which seems to fix the problem, Stefan --- lisp/subr.el 2012-10-06 17:29:15 +0000 +++ lisp/subr.el 2012-10-07 19:31:03 +0000 @@ -2143,7 +2143,9 @@ (setq first nil)) code)) -(defconst read-passwd-map +(defvar read-passwd-map + ;; BEWARE: `defconst' would purecopy it, breaking the sharing with + ;; minibuffer-local-map along the way! (let ((map (make-sparse-keymap))) (set-keymap-parent map minibuffer-local-map) (define-key map "\C-u" #'delete-minibuffer-contents) ;bug#12570