From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#12702: 24.2; Orgmode Refile complains "Not bookmark format" Date: Wed, 24 Oct 2012 13:57:34 -0400 Message-ID: References: <50855D96.9000302@univ-brest.fr> <03liexyx5m.fsf@fencepost.gnu.org> <5087B1AB.3030404@univ-brest.fr> <87d30729b0.fsf@bzg.ath.cx> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT X-Trace: ger.gmane.org 1351101502 23211 80.91.229.3 (24 Oct 2012 17:58:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Oct 2012 17:58:22 +0000 (UTC) Cc: 12702@debbugs.gnu.org, Jonathan Schaeffer To: Bastien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 24 19:58:29 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TR5Dm-0002XQ-RN for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Oct 2012 19:58:26 +0200 Original-Received: from localhost ([::1]:42462 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR5Df-0008Mi-9F for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Oct 2012 13:58:19 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR5Dc-0008GI-2i for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2012 13:58:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TR5DW-0006E8-FU for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2012 13:58:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR5DP-0006DA-LD; Wed, 24 Oct 2012 13:58:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TR5FK-0006Rx-7O; Wed, 24 Oct 2012 14:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Wed, 24 Oct 2012 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12702 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 12702-submit@debbugs.gnu.org id=B12702.135110157624741 (code B ref 12702); Wed, 24 Oct 2012 18:00:02 +0000 Original-Received: (at 12702) by debbugs.gnu.org; 24 Oct 2012 17:59:36 +0000 Original-Received: from localhost ([127.0.0.1]:59940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TR5Et-0006R0-TM for submit@debbugs.gnu.org; Wed, 24 Oct 2012 13:59:36 -0400 Original-Received: from relais.videotron.ca ([24.201.245.36]:19417) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TR5Es-0006Qt-4z for 12702@debbugs.gnu.org; Wed, 24 Oct 2012 13:59:34 -0400 Original-Received: from ceviche.home ([96.21.127.30]) by VL-VM-MR004.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0MCE00892SJYJ840@VL-VM-MR004.ip.videotron.ca> for 12702@debbugs.gnu.org; Wed, 24 Oct 2012 13:57:34 -0400 (EDT) Original-Received: by ceviche.home (Postfix, from userid 20848) id 89F6E661F0; Wed, 24 Oct 2012 13:57:34 -0400 (EDT) In-reply-to: <87d30729b0.fsf@bzg.ath.cx> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65990 Archived-At: >>> The error message makes sense ... as soon as you know where the problem >>> comes from :) >> Also, while it's good to signal to the user that his bookmark file is >> corrupted (and to make sure we don't overwrite it with something else), >> I don't see why that should prevent Org's Refile from working. > By default, org-refile and org-capture store bookmarks to the last > refiled/captured Org headline. (There is org-capture-bookmark in > case users want to deactivate this for captured headlines.) > We could skip this step in Org in case the bookmark format is > corrupted, or have a more informative message that makes clear to > the user that Org tries to store a bookmark. I don't know the details of what happens currently when the bookmark file is corrupted but at least such an occurrence shouldn't prevent org-refile from working (tho obviously in a degraded way). IOW, if needed we could wrap the calls to bookmark-set in with-demoted-errors, but maybe those errors are signaled late enough already that while the command signals an error, it did do what it was expected to do. Stefan