From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13831: 24.3.50; [PATCH] net-utils-mode have no revert-buffer function Date: Fri, 01 Mar 2013 09:29:23 -0500 Message-ID: References: <87liaam7dh.fsf@gmail.com> <87hakym6il.fsf@gmail.com> <87d2vmm3nh.fsf@gmail.com> <871uc1ese2.fsf@gmail.com> <87k3ptbtoj.fsf@gmail.com> <877gltm05y.fsf@gmail.com> <87vc9cgr2i.fsf@gmail.com> <87zjyny54l.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1362148224 26691 80.91.229.3 (1 Mar 2013 14:30:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 Mar 2013 14:30:24 +0000 (UTC) Cc: 13831@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 01 15:30:45 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UBQys-0006WC-Qi for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Mar 2013 15:30:38 +0100 Original-Received: from localhost ([::1]:58092 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBQyX-0001WF-CI for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Mar 2013 09:30:17 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:53804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBQyP-0001V4-Ve for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2013 09:30:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UBQyJ-0007VO-Ej for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2013 09:30:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBQyJ-0007Uo-92 for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2013 09:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UBR0G-0001aF-6W for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2013 09:32:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Mar 2013 14:32:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13831 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13831-submit@debbugs.gnu.org id=B13831.13621482986034 (code B ref 13831); Fri, 01 Mar 2013 14:32:03 +0000 Original-Received: (at 13831) by debbugs.gnu.org; 1 Mar 2013 14:31:38 +0000 Original-Received: from localhost ([127.0.0.1]:57707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UBQzj-0001ZB-NJ for submit@debbugs.gnu.org; Fri, 01 Mar 2013 09:31:33 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:60569) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UBQzf-0001Z0-Cn for 13831@debbugs.gnu.org; Fri, 01 Mar 2013 09:31:28 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpaTU/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IPAS-Result: Av8EABK/CFFFpaTU/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="2772573" Original-Received: from 69-165-164-212.dsl.teksavvy.com (HELO pastel.home) ([69.165.164.212]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 01 Mar 2013 09:29:23 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id D25446A69F; Fri, 1 Mar 2013 09:29:23 -0500 (EST) In-Reply-To: <87zjyny54l.fsf@gmail.com> (Thierry Volpiatto's message of "Fri, 01 Mar 2013 08:02:34 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:71981 Archived-At: > Here your patch modified, I have simplified > `net-utils-remove-ctrl-m-filter'. Actually, my patch is already in the trunk. Could you make the patch relative to trunk's version? > + (save-selected-window > + (set-buffer (process-buffer process)) > + (save-excursion > + (let ((inhibit-read-only t) > + (filtered-string output-string)) > + (while (string-match "\r" filtered-string) > + (setq filtered-string > + (replace-match "" nil nil filtered-string))) > + ;; Insert the text, moving the process-marker. > + (goto-char (process-mark process)) > + (insert filtered-string) > + (set-marker (process-mark process) (point)))))) This code does not affect the selected-window, so there shouldn't be any save-selected-window. Instead it should use with-current-buffer. BTW, I think the desired behavior is not the same for all net-utils tools. E.g. for ping, we'd like point to stay at the end. So you above change is good but it should be completed with changes in the relevant commands to set window-point-insertion-type when necessary. Stefan