emacspeak request: please update interactive spec for frameset-to-register

emacspeak request: please update interactive spec for frameset-to-register

[T. V. Raman]

Could we update the interactive calling spec for
frameset-to-register
from
(interactive "cFrameset to register: \nP")

to
(interactive (list (register-read-with-preview
		      "Frame configuration to register: ")
		     current-prefix-arg))

This would save me having to explicitly advice the calling spec
for that command in Emacspeak.  It would also align the code with frame-configuration-to-register

Re: emacspeak request: please update interactive spec for frameset-to-register

[Juanma Barranquero]

On Fri, Jan 31, 2014 at 4:11 PM, T. V. Raman <tv.raman.tv@gmail.com> wrote:

> Could we update the interactive calling spec for
> frameset-to-register
> to
> (interactive (list (register-read-with-preview
>                       "Frame configuration to register: ")
>                      current-prefix-arg))

Not exactly a bug fix. OK to install during the freeze, Stefan?

    J

Re: emacspeak request: please update interactive spec for frameset-to-register

[Stefan Monnier]

> Not exactly a bug fix. OK to install during the freeze, Stefan?

Borderline, indeed, but my mood tells to let it slide, so go for it,


        Stefan

Re: emacspeak request: please update interactive spec for frameset-to-register

[Juanma Barranquero]

> Borderline, indeed, but my mood tells to let it slide, so go for it,

Thanks. Small problem: we already have five "tiny change" patches from
T. V. Raman.  Quite likely this will push him over the 10-lines limit.

2011-04-08  T. V. Raman  <tv.raman.tv@gmail.com>  (tiny change)

        * xml.c (parse_region): Avoid creating spurious whitespace nodes.

2010-10-24  T. V. Raman  <tv.raman.tv@gmail.com>  (tiny change)

        * net/mairix.el (mairix-searches-mode-map):
        * mail/mspools.el (mspools-mode-map): Fix 2010-10-10 change.

2008-11-13  T. V. Raman  <raman@users.sourceforge.net>  (tiny change)

        * files.el (project-settings-file): New variable.
        (project-find-settings-file): Use it, instead of hardcoding
        .dir.settings.el.

2008-10-07  T. V. Raman  <raman@users.sourceforge.net>  (tiny change)

        * json.el (json-advance): Use forward-char.
        (json-skip-whitespace): Use skip-syntax-forward.

2007-08-17  T. V. Raman  <raman@users.sf.net>  (tiny change)

        * completion.el (symbol-under-point, symbol-before-point)
        (symbol-before-point-for-complete): Use buffer-substring-no-properties.

Re: emacspeak request: please update interactive spec for frameset-to-register

[Dmitry Gutov]

Juanma Barranquero <lekktu@gmail.com> writes:

> Thanks. Small problem: we already have five "tiny change" patches from
> T. V. Raman.  Quite likely this will push him over the 10-lines limit.

The limit is "15 or so":
http://www.gnu.org/prep/maintain/html_node/Legally-Significant.html#Legally-Significant

Re: emacspeak request: please update interactive spec for frameset-to-register

[Juanma Barranquero]

On Sun, Feb 2, 2014 at 5:35 AM, Dmitry Gutov <dgutov@yandex.ru> wrote:

> The limit is "15 or so":

Fair enough, but I haven't checked each of his changes to count the
exact number of lines. Over five tiny patches, seems like it's time to
get papers, I think.

    J

Re: emacspeak request: please update interactive spec for frameset-to-register

[Glenn Morris]

I independently came to the conclusion that this needed doing as part of
documenting NEWS changes, so was able to do it myself in good
conscience, thus side-stepping the assignment issue (till the next time,
so I still recommend addressing it).


Why does this function take an optional argument it does not use?

Re: emacspeak request: please update interactive spec for frameset-to-register

[Juanma Barranquero]

On Mon, Feb 3, 2014 at 1:42 AM, Glenn Morris <rgm@gnu.org> wrote:

> Why does this function take an optional argument it does not use?

Compatibility with frame-configuration-to-register, IIRC.

    J

Re: emacspeak request: please update interactive spec for frameset-to-register

[Glenn Morris]

Juanma Barranquero wrote:

> On Mon, Feb 3, 2014 at 1:42 AM, Glenn Morris <rgm@gnu.org> wrote:
>
>> Why does this function take an optional argument it does not use?
>
> Compatibility with frame-configuration-to-register, IIRC.

Why does the arg-spec have to be compatible? They are not aliases.

Also, frame-configuration-to-register does not use its second arg
either...

Re: emacspeak request: please update interactive spec for frameset-to-register

[Juanma Barranquero]

On Mon, Feb 3, 2014 at 1:53 AM, Glenn Morris <rgm@gnu.org> wrote:

> Why does the arg-spec have to be compatible? They are not aliases.
>
> Also, frame-configuration-to-register does not use its second arg
> either...

I bound frameset-to-register replacing
frame-configuration-to-register, so I just copied the profile. Call it
a bit of FUD; I was busy with frameset.el and wasn't really interested
in looking too much at the innards of register.el.

If you think that's unnecessary, feel free to fix it (modulo the
freeze and Stefan's opinion).

   J