Re: [Emacs-diffs] trunk r117006: * lisp/emacs-lisp/cl-macs.el (cl-struct-slot-offset): Mark as pure.

Re: [Emacs-diffs] trunk r117006: * lisp/emacs-lisp/cl-macs.el (cl-struct-slot-offset): Mark as pure.

[Daniel Colascione]

[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

On 04/21/2014 08:18 PM, Stefan Monnier wrote:
> ------------------------------------------------------------
> revno: 117006
> revision-id: monnier@iro.umontreal.ca-20140422031815-fc7amrf88mkuwh0r
> parent: dancol@dancol.org-20140421180019-po4wdeg7gqvvlh5d
> committer: Stefan Monnier <monnier@iro.umontreal.ca>
> branch nick: trunk
> timestamp: Mon 2014-04-21 23:18:15 -0400
> message:
>   * lisp/emacs-lisp/cl-macs.el (cl-struct-slot-offset): Mark as pure.

I expected the compiler to collapse redundant calls to pure functions,
but not to evaluate them completely at compile time. That's an elegant
approach.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

Re: [Emacs-diffs] trunk r117006: * lisp/emacs-lisp/cl-macs.el (cl-struct-slot-offset): Mark as pure.

[Stefan Monnier]

> I expected the compiler to collapse redundant calls to pure functions,

I wish it did, but sadly, it doesn't know how to do that.
We'd want another property for it, tho (something like `idempotent',
maybe), since that can be applied to different functions.


        Stefan