From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17348: 24.3.50; Cannot advice-add the same function :before and :after Date: Sat, 26 Apr 2014 08:46:13 -0400 Message-ID: References: <87vbtwl4sv.fsf@yahoo.fr> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1398516452 31458 80.91.229.3 (26 Apr 2014 12:47:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 26 Apr 2014 12:47:32 +0000 (UTC) Cc: 17348@debbugs.gnu.org To: Nicolas Richard Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 26 14:47:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1We20q-00074Z-Hp for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Apr 2014 14:47:24 +0200 Original-Received: from localhost ([::1]:33751 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1We20q-0005wu-0H for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Apr 2014 08:47:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1We20f-0005wp-Po for bug-gnu-emacs@gnu.org; Sat, 26 Apr 2014 08:47:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1We20V-0007uh-86 for bug-gnu-emacs@gnu.org; Sat, 26 Apr 2014 08:47:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1We20V-0007uc-4O for bug-gnu-emacs@gnu.org; Sat, 26 Apr 2014 08:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1We20U-0001q6-Eb for bug-gnu-emacs@gnu.org; Sat, 26 Apr 2014 08:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Apr 2014 12:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17348 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17348-submit@debbugs.gnu.org id=B17348.13985163806999 (code B ref 17348); Sat, 26 Apr 2014 12:47:02 +0000 Original-Received: (at 17348) by debbugs.gnu.org; 26 Apr 2014 12:46:20 +0000 Original-Received: from localhost ([127.0.0.1]:59056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1We1zn-0001op-KL for submit@debbugs.gnu.org; Sat, 26 Apr 2014 08:46:19 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:33925) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1We1zi-0001oZ-TT for 17348@debbugs.gnu.org; Sat, 26 Apr 2014 08:46:15 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNMCqOU/2dsb2JhbABZgwaDSr0vgw6BFxd0giYBAQRWIxALNBIUGA0kiAzSGReOegeEOASpGYFqg0wh X-IPAS-Result: ArYGAIDvNVNMCqOU/2dsb2JhbABZgwaDSr0vgw6BFxd0giYBAQRWIxALNBIUGA0kiAzSGReOegeEOASpGYFqg0wh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="59126033" Original-Received: from 76-10-163-148.dsl.teksavvy.com (HELO pastel.home) ([76.10.163.148]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 26 Apr 2014 08:46:13 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id B90BA600CA; Sat, 26 Apr 2014 08:46:13 -0400 (EDT) In-Reply-To: <87vbtwl4sv.fsf@yahoo.fr> (Nicolas Richard's message of "Sat, 26 Apr 2014 13:16:00 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88310 Archived-At: > (advice-add 'yftest :before #'yfcheck) > (advice-add 'yftest :after #'yfcheck) `advice-add' will not add the same function twice, indeed. Similarly to `add-hook'. This is done explicitly in advice--add-function: (when a ;; The advice is already present. Remove the old one, first. (setf (gv-deref ref) (advice--remove-function (gv-deref ref) (advice--car a)))) I guess we could change that, but then the notion of "removal" becomes more complicated. Stefan