From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Nicolas Richard <theonewiththeevillook@yahoo.fr>
Cc: 17348@debbugs.gnu.org
Subject: bug#17348: 24.3.50; Cannot advice-add the same function :before and :after
Date: Sat, 26 Apr 2014 08:46:13 -0400 [thread overview]
Message-ID: <jwv38h0462b.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87vbtwl4sv.fsf@yahoo.fr> (Nicolas Richard's message of "Sat, 26 Apr 2014 13:16:00 +0200")
> (advice-add 'yftest :before #'yfcheck)
> (advice-add 'yftest :after #'yfcheck)
`advice-add' will not add the same function twice, indeed.
Similarly to `add-hook'. This is done explicitly in advice--add-function:
(when a
;; The advice is already present. Remove the old one, first.
(setf (gv-deref ref)
(advice--remove-function (gv-deref ref) (advice--car a))))
I guess we could change that, but then the notion of "removal" becomes
more complicated.
Stefan
next prev parent reply other threads:[~2014-04-26 12:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-26 11:16 bug#17348: 24.3.50; Cannot advice-add the same function :before and :after Nicolas Richard
2014-04-26 12:46 ` Stefan Monnier [this message]
2014-04-26 20:22 ` Nicolas Richard
2014-05-01 20:47 ` Stefan Monnier
2014-05-10 20:09 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv38h0462b.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=17348@debbugs.gnu.org \
--cc=theonewiththeevillook@yahoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.