window.el has no provide

window.el has no provide

[Jordon Biondo]

Is there a reason that there is no provide in window.el? If not, can one be added?

diff --git lisp/window.el lisp/window.el
index abc6006..3f43a71 100644
--- lisp/window.el
+++ lisp/window.el
@@ -7990,4 +7990,6 @@ Otherwise, consult the value of `truncate-partial-width-windows'
 (define-key ctl-x-map "+" 'balance-windows)
 (define-key ctl-x-4-map "0" 'kill-buffer-and-window)
 
+(provide 'window)
+
 ;;; window.el ends here

Re: window.el has no provide

[Stefan Monnier]

> Is there a reason that there is no provide in window.el?

It's preloaded, so (require 'window) is never needed, and (featurep
'window) should always be t.

> If not, can one be added?

Of course, and it's probably a good idea.  I'm just curious what's
the motivation.


        Stefan

Re: window.el has no provide

[Jordon Biondo]

I was getting byte compilation errors when compiling my init.el

  init.el:631:10:Error: Required feature `window' was not provided

My init generates requires for all packages I have configurations for which is why I’m requiring ‘window in the first place. I can’t reliably recreate the issue, but when it does happen, as you would imagine, (featurep ‘window) is nil, even though window.el is loaded. I’ll report a bug if I can reliable recreate it.

Real problem or not, I thought it was weird that there was no provide.

> On Feb 12, 2015, at 1:45 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> 
>> Is there a reason that there is no provide in window.el?
> 
> It's preloaded, so (require 'window) is never needed, and (featurep
> 'window) should always be t.
> 
>> If not, can one be added?
> 
> Of course, and it's probably a good idea.  I'm just curious what's
> the motivation.
> 
> 
>        Stefan

Re: window.el has no provide

[Stefan Monnier]

> My init generates requires for all packages I have configurations for which
> is why I’m requiring ‘window in the first place.

Beware: some config vars can move because of file-renamings, so the
`require' might then fail.  Other problems can be that some custom vars
might be in files which shouldn't directly be required (you should
require the "parent" file instead).

FWIW, I don't have a single `require' in my ~/.emacs which sits at
about 60KB.

Usually `require' is needed in Elisp packages, but not in ~/.emacs.
So if/when you do need it there, it's worth reporting it via
M-x report-emacs-bug: there are definitely cases where it's not a bug
that the user needs to do a `require', but for "normal" use it
shouldn't be needed.

> Real problem or not, I thought it was weird that there was no provide.

Many of the preloaded files aren't really considered as independent
packages, instead they're just a convenient place to group related
functionality of the base system.
So they don't come with a `provide' statement.
I think it's good to structure even this "base system" as "independent"
packages, but there are many other things which would be nice, so we
can't do them all.


        Stefan