all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Alan Mackenzie <acm@muc.de>
Cc: Daniel Colascione <dancol@dancol.org>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-24 d69e9f1: CC Mode: Stop Font Lock forcing fontification from BOL. Fixes debbugs#19669.
Date: Fri, 20 Mar 2015 14:05:48 -0400	[thread overview]
Message-ID: <jwv384zwnv8.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20150320163027.GB3493@acm.fritz.box> (Alan Mackenzie's message of "Fri, 20 Mar 2015 16:30:28 +0000")

>> There's your problem: your current setup needs the starting point to be
>> either before "union" or after the first open brace.
>> It breaks down if it's between the two.  That's the problem you need to fix.
> Not really.  CC Mode is quite capable of handling the Font Lock region
> starting at BOL2.

You yourself told me that the region had to start after the brace.

> The problem is, when that starting point needs to be
> after the brace on L2, Font Lock moves the starting point somewhere
> else, fouling up the font locking.

I'm confused: "somewhere else" is typically BOL2.
Here you say this fouls up font-locking, but above you said CC-Mode is
quite capable of handling a font-lock region starting at BOL2.

> One place which is causing me puzzlement is in jit-lock-fontify-now.
> It's this bit:

As you know, jit-lock is irrelevant to those kinds of font-lock problems
(in the sense that it's always possible to trigger the same problems
without the use of jit-lock, tho it may require some time to figure
out a triggering sequence).

> The only way `start' can be before `orig-start' is on the first line of
> the fl region, and start is moved to BOL.  Why is it necessary to go to
> all the expense of using `run-with-timer' rather than just fixing things
> inside `jit-lock-fontify-now'?  What is the use case?

It's explained in the comment.  Which part of the comment don't you understand?
By the time jit-lock is called the redisplay up to orig-start has
already been done (you can assume it's already drawn on the screen).


        Stefan



  parent reply	other threads:[~2015-03-20 18:05 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150201212213.17840.3710@vcs.savannah.gnu.org>
     [not found] ` <E1YI1y9-0004eO-Re@vcs.savannah.gnu.org>
2015-02-02 18:50   ` [Emacs-diffs] emacs-24 d69e9f1: CC Mode: Stop Font Lock forcing fontification from BOL. Fixes debbugs#19669 Stefan Monnier
2015-02-02 19:27     ` Alan Mackenzie
2015-02-03  2:12       ` Stefan Monnier
2015-02-02 18:54   ` Stefan Monnier
2015-02-02 21:39     ` Alan Mackenzie
2015-02-03  2:26       ` Stefan Monnier
2015-02-07 12:27         ` Alan Mackenzie
2015-02-07 15:29           ` Stefan Monnier
2015-02-07 15:40             ` Alan Mackenzie
2015-03-16 23:53   ` Daniel Colascione
2015-03-18 12:08     ` Alan Mackenzie
2015-03-19  3:34       ` Daniel Colascione
2015-03-19  9:31         ` Alan Mackenzie
2015-03-19 13:49           ` Stefan Monnier
2015-03-19 20:37             ` Alan Mackenzie
2015-03-19 20:56               ` Stefan Monnier
2015-03-20 16:30                 ` Alan Mackenzie
2015-03-20 16:34                   ` Daniel Colascione
2015-03-20 17:29                     ` Alan Mackenzie
2015-03-20 21:25                       ` Daniel Colascione
2015-03-20 22:30                         ` Alan Mackenzie
2015-03-20 18:05                   ` Stefan Monnier [this message]
2015-03-20 21:12                     ` Alan Mackenzie
2015-03-20 22:01                       ` Stefan Monnier
2015-03-30 16:44     ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv384zwnv8.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=acm@muc.de \
    --cc=dancol@dancol.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.