From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: What to do for faster `remove-duplicates'? Date: Wed, 06 May 2015 08:59:33 -0400 Message-ID: References: <87383atb2p.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1430917206 21328 80.91.229.3 (6 May 2015 13:00:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 May 2015 13:00:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: Oleh Krehel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 06 14:59:58 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ypyvb-0003s0-Jq for ged-emacs-devel@m.gmane.org; Wed, 06 May 2015 14:59:55 +0200 Original-Received: from localhost ([::1]:44782 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ypyva-0001Qz-TB for ged-emacs-devel@m.gmane.org; Wed, 06 May 2015 08:59:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpyvN-0001Qe-2b for emacs-devel@gnu.org; Wed, 06 May 2015 08:59:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpyvH-0002jX-Hj for emacs-devel@gnu.org; Wed, 06 May 2015 08:59:41 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:21332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpyvH-0002jR-ES for emacs-devel@gnu.org; Wed, 06 May 2015 08:59:35 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgUFAGvvdVRFpYts/2dsb2JhbAA3gVOhb4EIgXUBAQQBViMFCwsOJhIUGA0kiBOiEYxkCQECAQKDPgODcASjY4RY X-IPAS-Result: AgUFAGvvdVRFpYts/2dsb2JhbAA3gVOhb4EIgXUBAQQBViMFCwsOJhIUGA0kiBOiEYxkCQECAQKDPgODcASjY4RY X-IronPort-AV: E=Sophos;i="5.11,557,1422939600"; d="scan'208";a="118419457" Original-Received: from 69-165-139-108.dsl.teksavvy.com (HELO pastel.home) ([69.165.139.108]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 06 May 2015 08:59:33 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 273122214; Wed, 6 May 2015 08:59:33 -0400 (EDT) In-Reply-To: <87383atb2p.fsf@gmail.com> (Oleh Krehel's message of "Wed, 06 May 2015 09:33:02 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:186277 Archived-At: > So should `cl-remove-duplicates' be a 2-in-1 (lists for small input, Don't know/don't care about cl-remove-duplicates, but for delete-dups, I'd welcome a patch which switches to a hash-table after the Nth element. Stefan PS: BTW, helm-fast-remove-dups's docstring says: This is same as `remove-duplicates' but with memoisation. but it doesn't actually use memoization, AFAICT.