* Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change 6e0ffbf 2/3: Stylistic alteration.
[not found] ` <E1ZbyGU-00030T-HJ@vcs.savannah.gnu.org>
@ 2015-09-16 2:25 ` Stefan Monnier
2015-09-16 9:36 ` Stephen Berman
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2015-09-16 2:25 UTC (permalink / raw)
To: emacs-devel; +Cc: Phillip Lord
> + if( ! NILP( n ) )
No, that should be
if (! NILP (n))
Again, please take a look at the megabytes of code in src/*.c for examples.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change 6e0ffbf 2/3: Stylistic alteration.
2015-09-16 2:25 ` [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change 6e0ffbf 2/3: Stylistic alteration Stefan Monnier
@ 2015-09-16 9:36 ` Stephen Berman
2015-09-16 13:23 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Berman @ 2015-09-16 9:36 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Phillip Lord, emacs-devel
On Tue, 15 Sep 2015 22:25:11 -0400 Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> + if( ! NILP( n ) )
>
> No, that should be
>
> if (! NILP (n))
>
> Again, please take a look at the megabytes of code in src/*.c for examples.
FWIW, a space between `!' and `NILP' is much less common than no space:
steve@rosalinde:~> grep "! NILP" git/emacs/src/*\.c | wc -l
573
steve@rosalinde:~> grep "\!NILP" git/emacs/src/*\.c | wc -l
1481
Steve Berman
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change 6e0ffbf 2/3: Stylistic alteration.
2015-09-16 9:36 ` Stephen Berman
@ 2015-09-16 13:23 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2015-09-16 13:23 UTC (permalink / raw)
To: Stephen Berman; +Cc: Phillip Lord, emacs-devel
>> if (! NILP (n))
>> Again, please take a look at the megabytes of code in src/*.c for examples.
> FWIW, a space between `!' and `NILP' is much less common than no space:
Indeed, I prefer not to put a space in there, but opinions vary and
AFAIK the GNU Coding Standard doesn't impose a particular choice here,
so I prefer to leave it to the coder's taste.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-16 13:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150915215948.11475.62011@vcs.savannah.gnu.org>
[not found] ` <E1ZbyGU-00030T-HJ@vcs.savannah.gnu.org>
2015-09-16 2:25 ` [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change 6e0ffbf 2/3: Stylistic alteration Stefan Monnier
2015-09-16 9:36 ` Stephen Berman
2015-09-16 13:23 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.