From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] fix/undo-point-in-wrong-place 6b3cfe4 4/4: Prepare for record now separate function. Date: Wed, 25 Nov 2015 23:00:35 -0500 Message-ID: References: <20151120221320.21643.45342@vcs.savannah.gnu.org> <87k2p8aa0n.fsf@russet.org.uk> <87vb8py9wc.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1448510490 28759 80.91.229.3 (26 Nov 2015 04:01:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 26 Nov 2015 04:01:30 +0000 (UTC) Cc: emacs-devel@gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 26 05:01:21 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a1njn-0006g2-AQ for ged-emacs-devel@m.gmane.org; Thu, 26 Nov 2015 05:00:51 +0100 Original-Received: from localhost ([::1]:48966 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1njp-00038E-BF for ged-emacs-devel@m.gmane.org; Wed, 25 Nov 2015 23:00:53 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1njb-000387-N9 for emacs-devel@gnu.org; Wed, 25 Nov 2015 23:00:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1njY-00077P-CD for emacs-devel@gnu.org; Wed, 25 Nov 2015 23:00:39 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:49622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1njY-00077L-59 for emacs-devel@gnu.org; Wed, 25 Nov 2015 23:00:36 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CtCwA731xV/yr292hcgxCEAsEMCYdLBAICgTw5FAEBAQEBAQGBCkEFg10BAQMBViMFCws0BwsUGA1SiAkIzyMBAQgBAQEBHos6hQUHhC0FjDCSZ5IUg1kjgjuBWyCCeAEBAQ X-IPAS-Result: A0CtCwA731xV/yr292hcgxCEAsEMCYdLBAICgTw5FAEBAQEBAQGBCkEFg10BAQMBViMFCws0BwsUGA1SiAkIzyMBAQgBAQEBHos6hQUHhC0FjDCSZ5IUg1kjgjuBWyCCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="179421356" Original-Received: from 104-247-246-42.cpe.teksavvy.com (HELO fmsmemgm.homelinux.net) ([104.247.246.42]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 25 Nov 2015 23:00:36 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 228C9AE065; Wed, 25 Nov 2015 23:00:35 -0500 (EST) In-Reply-To: <87vb8py9wc.fsf@russet.org.uk> (Phillip Lord's message of "Wed, 25 Nov 2015 22:46:59 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195274 Archived-At: > Does this seem a reasonable solution (I've used the idea behind your > patch, but with variables that already exist in keyboard.c)? As pointed out in the reply to the actual commit-diff, the new code has another problem: it always uses the "point at beginning of command", which is usually right but not when an undo-boundary was pushed between "beginning of command" and the moment when we try to record point. Stefan