From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Annotation] New package: smart-yank.el Date: Mon, 16 May 2016 20:38:23 -0400 Message-ID: References: <87inyd3708.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1463445475 30441 80.91.229.3 (17 May 2016 00:37:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 May 2016 00:37:55 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 17 02:37:49 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b2T1A-0001FL-Pr for ged-emacs-devel@m.gmane.org; Tue, 17 May 2016 02:37:48 +0200 Original-Received: from localhost ([::1]:47903 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2T19-0002Oq-Vm for ged-emacs-devel@m.gmane.org; Mon, 16 May 2016 20:37:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36202) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2T16-0002Kw-6P for emacs-devel@gnu.org; Mon, 16 May 2016 20:37:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2T11-00019I-S9 for emacs-devel@gnu.org; Mon, 16 May 2016 20:37:43 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:36798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2T11-000198-L4 for emacs-devel@gnu.org; Mon, 16 May 2016 20:37:39 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1b2T0z-0001By-Mk for emacs-devel@gnu.org; Tue, 17 May 2016 02:37:37 +0200 Original-Received: from 45.72.245.134 ([45.72.245.134]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 17 May 2016 02:37:37 +0200 Original-Received: from monnier by 45.72.245.134 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 17 May 2016 02:37:37 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 29 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 45.72.245.134 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:l1rnhPkz2vRDzcWTJDClVm7JwoA= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203875 Archived-At: > I intend to upload the attached package "smart-yank.el" to Gnu Elpa > (does that work again btw?). > Any comments, objections, ...or something like that? Thanks. Sounds good to me. See nitpicks below. Stefan > (let ((r (smart-yank--stopwatch))) > (defun smart-yank-yank-pop (&optional arg) [...] > (declare-function smart-yank-yank-pop 'smart-yank) An arguably cleaner way to get the same result would be: (defalias 'smart-yank-yank-pop (let ((r (smart-yank--stopwatch))) (lambda (&optional arg) "blabla" ...))) > (define-minor-mode smart-yank-mode [...] > :global t :keymap smart-yank-map Please name the keymap `smart-yank-mode-map' and don't use the :keymap argument at all.