From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#25400: M-p in diff-mode jumps too far Date: Sun, 08 Jan 2017 23:34:52 -0500 Message-ID: References: <87h959t9n3.fsf@udel.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1483936517 8188 195.159.176.226 (9 Jan 2017 04:35:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 9 Jan 2017 04:35:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 25400@debbugs.gnu.org To: Mark Oteiza Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 09 05:35:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQRfq-0001Kg-SE for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Jan 2017 05:35:10 +0100 Original-Received: from localhost ([::1]:37134 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQRfv-0000FQ-2i for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Jan 2017 23:35:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34035) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQRfl-0000BE-MU for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2017 23:35:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQRfi-0003RF-Io for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2017 23:35:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60171) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cQRfi-0003QR-Er for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2017 23:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cQRfh-0002iJ-UU for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2017 23:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Jan 2017 04:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25400 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25400-submit@debbugs.gnu.org id=B25400.148393649710417 (code B ref 25400); Mon, 09 Jan 2017 04:35:01 +0000 Original-Received: (at 25400) by debbugs.gnu.org; 9 Jan 2017 04:34:57 +0000 Original-Received: from localhost ([127.0.0.1]:47337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQRfd-0002hx-Dy for submit@debbugs.gnu.org; Sun, 08 Jan 2017 23:34:57 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:43557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQRfa-0002hk-Jb for 25400@debbugs.gnu.org; Sun, 08 Jan 2017 23:34:55 -0500 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v094Yqc6001543; Sun, 8 Jan 2017 23:34:52 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 76B7766200; Sun, 8 Jan 2017 23:34:52 -0500 (EST) In-Reply-To: <87h959t9n3.fsf@udel.edu> (Mark Oteiza's message of "Sun, 08 Jan 2017 18:27:44 -0500") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV5913=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5913> : inlines <5618> : streams <1728278> : uri <2355059> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127924 Archived-At: >> In a buffer with more than one hunk, if I'm in the middle of hunk number >> N, diff-hunk-prev (usually bound to M-p) jumps to the header of hunk >> number N-1 rather than to the header of hunk N. >> >> This is contrary to the usual behavior of Emacs's navigation commands. > Implemented in 2c8a7e5 (bug#17544). Apparently it was intended. > https://lists.gnu.org/archive/html/emacs-devel/2016-12/msg00222.html > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25105 Maybe it's OK to change the behavior of `diff-hunk-prev` this way when called from Elisp (I still find it odd, but it might work better for the callers), but it's clearly not a good idea for M-p to behave this way. As pointed out elsewhere, it's particularly obnoxious from EOB (in which case, you're not really "within N" but you're virtually on "the header of the non-existent hunk N+1", so going to the header of N-1 is really wrong). I also dislike the fact that M-n doesn't let me get to EOB. Stefan