From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] feature/byte-switch 086c4ea: * src/bytecode.c: (exec_byte_code) Use hash_lookup for Bswitch Date: Wed, 18 Jan 2017 12:48:53 -0500 Message-ID: References: <20170118171311.10996.72260@vcs.savannah.gnu.org> <20170118171311.A84EA220125@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1484763057 31566 195.159.176.226 (18 Jan 2017 18:10:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 18 Jan 2017 18:10:57 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Vibhav Pant To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 18 19:10:53 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cTuh0-0006sC-Hd for ged-emacs-devel@m.gmane.org; Wed, 18 Jan 2017 19:10:42 +0100 Original-Received: from localhost ([::1]:43279 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTuh3-0006W0-9x for ged-emacs-devel@m.gmane.org; Wed, 18 Jan 2017 13:10:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTuLx-00067a-OF for emacs-devel@gnu.org; Wed, 18 Jan 2017 12:48:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTuLu-0005QC-MM for emacs-devel@gnu.org; Wed, 18 Jan 2017 12:48:57 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:47402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTuLu-0005Pn-Gb for emacs-devel@gnu.org; Wed, 18 Jan 2017 12:48:54 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v0IHmmwa030965; Wed, 18 Jan 2017 12:48:48 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 3AD64601EB; Wed, 18 Jan 2017 12:48:53 -0500 (EST) In-Reply-To: <20170118171311.A84EA220125@vcs.savannah.gnu.org> (Vibhav Pant's message of "Wed, 18 Jan 2017 17:13:11 +0000 (UTC)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV5923=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5923> : inlines <5633> : streams <1729636> : uri <2360200> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211381 Archived-At: > * src/bytecode.c: (exec_byte_code) Use hash_lookup for Bswitch > Fgethash type checks the provided table object, which is unnecessary > for compiled bytecode. While it's true that we can cause a core dump of Emacs if we feed it an invalid .elc file, that's a "feature" I'd rather shrink rather than generalize. Stefan