From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/exwm 2b7449e: ; Do not cache events for non-`exwm-mode' buffers Date: Sun, 23 Apr 2017 11:59:24 -0400 Message-ID: References: <20170423154054.5792.49179@vcs0.savannah.gnu.org> <20170423154055.0210C2603F@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1492963177 31616 195.159.176.226 (23 Apr 2017 15:59:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 23 Apr 2017 15:59:37 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Chris Feng To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 23 17:59:33 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2JvB-00084g-19 for ged-emacs-devel@m.gmane.org; Sun, 23 Apr 2017 17:59:33 +0200 Original-Received: from localhost ([::1]:39651 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2JvD-0003Iy-Lo for ged-emacs-devel@m.gmane.org; Sun, 23 Apr 2017 11:59:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2Jv8-0003It-JX for emacs-devel@gnu.org; Sun, 23 Apr 2017 11:59:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2Jv4-0000Bz-Od for emacs-devel@gnu.org; Sun, 23 Apr 2017 11:59:30 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:46810) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d2Jv4-0000BR-JZ for emacs-devel@gnu.org; Sun, 23 Apr 2017 11:59:26 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AsIQDszfxY//TvSC1cHQEFAQsBg1SFBoVZhX2RHAGXSRyGAAIEAgKEC0UTAQIBAQEBAQEBayiFFgZWIxALNBIUGA2KU612ixIBAQEBBgImi0mFI4UZBZ1BlG4BiHyGcpQZNyCBBiYdCC2FYoFmJIlrAQEB X-IPAS-Result: A0AsIQDszfxY//TvSC1cHQEFAQsBg1SFBoVZhX2RHAGXSRyGAAIEAgKEC0UTAQIBAQEBAQEBayiFFgZWIxALNBIUGA2KU612ixIBAQEBBgImi0mFI4UZBZ1BlG4BiHyGcpQZNyCBBiYdCC2FYoFmJIlrAQEB X-IronPort-AV: E=Sophos;i="5.37,240,1488862800"; d="scan'208";a="309094002" Original-Received: from 45-72-239-244.cpe.teksavvy.com (HELO ceviche.home) ([45.72.239.244]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 23 Apr 2017 11:59:24 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 51C82662FE; Sun, 23 Apr 2017 11:59:24 -0400 (EDT) In-Reply-To: <20170423154055.0210C2603F@vcs0.savannah.gnu.org> (Chris Feng's message of "Sun, 23 Apr 2017 11:40:54 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214246 Archived-At: > + (if (not (eq major-mode 'exwm-mode)) Better use `derived-mode-p' rather than test `major-mode' directly. Or even better in general: in exwm-mode, set a buffer-local variable that represents the thing you want to test, and then test that var here. Stefan