From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.help Subject: Re: profiler-report seems to be missing data? Date: Sun, 19 Aug 2018 01:06:20 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1534655096 8937 195.159.176.226 (19 Aug 2018 05:04:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 19 Aug 2018 05:04:56 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Sun Aug 19 07:04:52 2018 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frFtT-0002EG-Pq for geh-help-gnu-emacs@m.gmane.org; Sun, 19 Aug 2018 07:04:51 +0200 Original-Received: from localhost ([::1]:41602 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frFva-0003Mb-8l for geh-help-gnu-emacs@m.gmane.org; Sun, 19 Aug 2018 01:07:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frFv5-0003MJ-Fe for help-gnu-emacs@gnu.org; Sun, 19 Aug 2018 01:06:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frFv2-0000Ib-9e for help-gnu-emacs@gnu.org; Sun, 19 Aug 2018 01:06:31 -0400 Original-Received: from [195.159.176.226] (port=33087 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1frFv2-0000II-3i for help-gnu-emacs@gnu.org; Sun, 19 Aug 2018 01:06:28 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1frFst-0001WW-J9 for help-gnu-emacs@gnu.org; Sun, 19 Aug 2018 07:04:15 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 23 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:QDI+JMk1wkokE8lL+I1eodEWYNI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.org gmane.emacs.help:117692 Archived-At: > Byte compiling the file didn't seem to have much effect: let* was still > blamed for the vast majority of the runtime (57%). `let*` does not exist in byte-compiled code (it's decomposed into various other byte-codes instead), so its presence in the profile indicates that somehow non-compiled code is executed. > - The overall number of CPU samples didn't change, I think indicating > that eliminating the let* didn't in fact speed up the code. (In both cases, > I ran ftf-find-file once, which took 4-5 seconds.) > - The samples that were originally blamed on let* are instead blamed > largely on cons and gethash now, which in my opinion seems more likely > > My suspicion here is that let* and the profiler are having some bad > interaction where the samples are incorrectly being attributed to let* when > they should be instead attributed to code called within the let*. Stefan, > do you think I'm interpreting this correctly? Sounds possible, yes. Not sure if it's specific to `let*`, tho. [ E.g. maybe it's just that the leaf of each stack trace gets lost? ] Stefan