From: Stefan Monnier <monnier@iro.umontreal.ca>
To: help-gnu-emacs@gnu.org
Subject: Re: profiler-report seems to be missing data?
Date: Sun, 19 Aug 2018 01:06:20 -0400 [thread overview]
Message-ID: <jwv36vb0x0w.fsf-monnier+gmane.emacs.help@gnu.org> (raw)
In-Reply-To: CAHV0hAgxWz4Gx5r0MkS+REtxQbNJBOQAhCRMc6xK6dW+c9yJFg@mail.gmail.com
> Byte compiling the file didn't seem to have much effect: let* was still
> blamed for the vast majority of the runtime (57%).
`let*` does not exist in byte-compiled code (it's decomposed into
various other byte-codes instead), so its presence in the profile
indicates that somehow non-compiled code is executed.
> - The overall number of CPU samples didn't change, I think indicating
> that eliminating the let* didn't in fact speed up the code. (In both cases,
> I ran ftf-find-file once, which took 4-5 seconds.)
> - The samples that were originally blamed on let* are instead blamed
> largely on cons and gethash now, which in my opinion seems more likely
>
> My suspicion here is that let* and the profiler are having some bad
> interaction where the samples are incorrectly being attributed to let* when
> they should be instead attributed to code called within the let*. Stefan,
> do you think I'm interpreting this correctly?
Sounds possible, yes. Not sure if it's specific to `let*`, tho.
[ E.g. maybe it's just that the leaf of each stack trace gets lost? ]
Stefan
prev parent reply other threads:[~2018-08-19 5:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 15:00 profiler-report seems to be missing data? Charlie Andrews
2018-08-15 18:46 ` Eli Zaretskii
2018-08-16 13:47 ` Charlie Andrews
2018-08-16 14:19 ` Eli Zaretskii
2018-08-16 15:32 ` Michael Heerdegen
2018-08-16 17:12 ` Charlie Andrews
2018-08-16 17:28 ` Eli Zaretskii
2018-08-16 17:33 ` Charlie Andrews
2018-08-16 18:00 ` Eli Zaretskii
2018-08-16 18:48 ` Michael Heerdegen
2018-08-16 18:59 ` Eli Zaretskii
2018-08-16 18:54 ` Michael Heerdegen
2018-08-16 22:47 ` Stefan Monnier
2018-08-17 15:36 ` Charlie Andrews
2018-08-19 5:06 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv36vb0x0w.fsf-monnier+gmane.emacs.help@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.