From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#32460: 27.0.50; diff-mode sometimes doesn't refine hunks Date: Thu, 07 Mar 2019 22:07:30 -0500 Message-ID: References: <87zhxmhz4a.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="176095"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 32460@debbugs.gnu.org, Juri Linkov To: charles@aurox.ch (Charles A. Roelli) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 08 04:08:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h25rr-000jbm-AB for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Mar 2019 04:08:15 +0100 Original-Received: from localhost ([127.0.0.1]:36275 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h25rq-0004ww-AJ for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Mar 2019 22:08:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h25rk-0004wq-MJ for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 22:08:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h25rg-0000cI-QS for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 22:08:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50431) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h25re-0000al-I4 for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 22:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h25re-0004PI-Ad for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 22:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Mar 2019 03:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32460 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 32460-submit@debbugs.gnu.org id=B32460.155201446216911 (code B ref 32460); Fri, 08 Mar 2019 03:08:02 +0000 Original-Received: (at 32460) by debbugs.gnu.org; 8 Mar 2019 03:07:42 +0000 Original-Received: from localhost ([127.0.0.1]:35742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h25rJ-0004Oh-Md for submit@debbugs.gnu.org; Thu, 07 Mar 2019 22:07:41 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:45954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h25rH-0004OZ-TW for 32460@debbugs.gnu.org; Thu, 07 Mar 2019 22:07:40 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x2837U9o004945; Thu, 7 Mar 2019 22:07:30 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 1CCDE6A478; Thu, 7 Mar 2019 22:07:30 -0500 (EST) In-Reply-To: (Charles A. Roelli's message of "Thu, 07 Mar 2019 20:26:11 +0100") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6498=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6498> : inlines <7029> : streams <1815071> : uri <2808719> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156133 Archived-At: > As Juri suggested, the fix for Bug#32991 probably fixed this bug. As part of the fix for Bug#32991, I rewrote the code that visits "all" hunks in a region, because that code had a bug which basically made it skip every other hunk: in practice with jit-lock (where the granularity is small enough that the region considered rarely contains more than one hunk), it tended to "arbitrarily" miss some hunks every once in a while (regardless of diff-hunk-next). Not sure if this error was the cause of bug#32460 since you mention interaction with diff-hunk-next, but I think it's indeed better to close the bug for now and reopen it (or a new one) if it re-appears. Stefan