From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacs-26 8f18d12: Improve documentation of decoding into a unibyte buffer Date: Wed, 29 May 2019 14:58:57 -0400 Message-ID: References: <20190525191039.14136.23307@vcs0.savannah.gnu.org> <20190525191040.CCD6C207F5@vcs0.savannah.gnu.org> <83v9xv2649.fsf@gnu.org> <83imtv1fbf.fsf@gnu.org> <7F0B61E6-C0CA-449B-B432-095569589168@gnu.org> <83y32qzk9b.fsf@gnu.org> <83pno2za3d.fsf@gnu.org> <83blzmyo5h.fsf@gnu.org> <83muj5xgw9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="84612"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 29 20:59:16 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hW3nA-000Lq5-0a for ged-emacs-devel@m.gmane.org; Wed, 29 May 2019 20:59:16 +0200 Original-Received: from localhost ([127.0.0.1]:59317 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hW3n8-00034z-QG for ged-emacs-devel@m.gmane.org; Wed, 29 May 2019 14:59:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37543) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hW3n2-00034t-TB for emacs-devel@gnu.org; Wed, 29 May 2019 14:59:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hW3n1-0005QL-SB for emacs-devel@gnu.org; Wed, 29 May 2019 14:59:08 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:21129) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hW3mv-0005Ly-7g; Wed, 29 May 2019 14:59:01 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E295F442DDA; Wed, 29 May 2019 14:58:59 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C2E70442DD5; Wed, 29 May 2019 14:58:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1559156338; bh=pw1j63vWseqgzLWNEwGU12G+aVWTkImARPmU37N5ieg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=PdRRV/jnT/YZCNToA4jWNQ81HvcdVcaRkNzhzxVHxYfEnJ2nzbhP/vHIHx2EsSczq Y2KCEEs16b9ZFFd+4YXXeUGboqAgCJ0PcIya5TlRCK9BO54a7JCdkTr2dwnAfy/Gh1 SgAUaaWdf+Q45jul6XKTT94wfQpxpfNntGfe3HYY3yYkUumNENZVYb3djISh2VQosP U5JXKUK2VHyVi/4EnhW9C+7eDX+XtSvjtcgUEjKHaJqPj+P0Q6SueBryUNa3JZMZN3 feyEQx0kDDViF5Mqloo7ZxNYgdC7fDb7Ips7k66g4MdteSqM6GBwEhxQe5Eu4Ck2J6 gCXv29Tn+KkUQ== Original-Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9B806120C73; Wed, 29 May 2019 14:58:58 -0400 (EDT) In-Reply-To: <83muj5xgw9.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 29 May 2019 21:19:34 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237160 Archived-At: > > I don't think there was much to discuss about it. > Unilaterally. Yes, it's was a clear and simple bug-fix, AFAIK. >> PS: I added checks in encoding/decoding functions to signal errors when >> decoding from multibyte and encoding from unibyte (in my local Emacs), >> and that's been tremendously useful to track down and fix encoding bugs >> in Gnus. > I have nothing against you making these changes locally to catch > bugs. I sometimes do similar things in my locale version of the code. Yes, and this experience showed me that it's a good practice to follow (I don't mean "adding checks" but "align unibyte/multibyte with encoded/decoded"). BTW, I think we should add such checks in `master` (but make them conditional on a variable like `check-encoding/decoding-strictly-for-debugging-purposes` which would of course default to nil). Stefan