From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "T.V Raman" <raman@google.com>
Cc: 40688@debbugs.gnu.org
Subject: bug#40688: 28.0.50; Advice And ByteCompile Behavior Change
Date: Sun, 03 May 2020 16:42:38 -0400 [thread overview]
Message-ID: <jwv368ghhwe.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <p914ksxm42e.fsf@google.com> (T. V. Raman's message of "Sun, 03 May 2020 08:27:37 -0700")
> I didn't mean the -j bit in building emacs, conjecture is that emacspeak
> breaks if -j is used.
I was pointing out that Emacs's own use of `-j` to build the `lisp`
subdir indicates that it's OK to have missing dependencies on the `.elc`
files (and hence sometimes the .el file is loaded and sometimes the
`.elc`, depending on the compilation order; or even the `.el` file is
loaded while the corresponding `.elc` file is being generated).
Of course, if your `.el` files are generated by makefile rules that's
a completely different question.
Stefan
>>> 4. As mentioned in this bug report at the outset I started seeing
>>> strange behavior (that also appeared non-deterministic across builds)
>>> where it felt like some of the advice was not defined (incidentally when
>>> the bug bit yesterday, C-h o still indicated the functions were
>>> adviced).
>>
>> If it bites again, could you try and post (to the extent possible,
>> obviously) the function name, the output of (symbol-function
>> <thefunction>) along with as much as possible a concrete and detailed
>> description of an actual call's behavior on that function where we see
>> that the advice wasn't called?
>>
>>> So wild conjecture: Given make -j (the Makefile does impose some
>>> dependency order but not all)
>>> is it possible that things go south if something that is needed during
>>> the build of module-a.el gets byte-compiled *after* module-a.el?
>>
>> In theory, no. I (and many other people) build Emacs's `lisp` subdir in
>> parallel, and there are basically no dependencies in the makefile to try
>> and make sure files get compiled before they're used. We've had some
>> corner case problems with it, but all the ones I know have been fixed.
>>
>>
>> Stefan
>>
>>
>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>>
>>>> IIUC after recompiling everything the problem disappeared. If you
>>>> can't reproduce it any more, than I guess we can only close this
>>>> bug.
>>>>
>>>>> As an example, Module emacspeak-advice.el advices vc-next-action --- and
>>>>> this module (emacspeak-advice) is loaded early on during emacspeak
>>>>> initialization.
>>>>>
>>>>> When I later call vc-next-action during an emacs session and the
>>>>> autoload pulls in vc.el, the advice definition loaded earlier is not
>>>>> activated -- I have to explicitly reload module emacspeak-advice.
>>>>
>>>> In case you can still reproduce the problem, please show us what
>>>> `C-h o vc-next-action` tells you when you think it should have the
>>>> advice applied yet its behavior doesn't seem to be affected.
>>>>
>>>>
>>>> Stefan
>>>>
>>
next prev parent reply other threads:[~2020-05-03 20:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 20:35 bug#40688: 28.0.50; Advice And ByteCompile Behavior Change T.V Raman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-04-19 16:49 ` Stefan Monnier
2020-04-19 17:21 ` T.V Raman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-04-19 17:28 ` Stefan Monnier
2020-05-03 14:16 ` T.V Raman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-05-03 15:08 ` Stefan Monnier
2020-05-03 15:27 ` T.V Raman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-05-03 20:42 ` Stefan Monnier [this message]
2020-05-04 0:26 ` T.V Raman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-05-04 3:03 ` Stefan Monnier
2020-05-04 16:18 ` Glenn Morris
2020-05-04 16:21 ` T.V Raman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-05-03 16:14 ` Eli Zaretskii
2020-05-03 16:19 ` T.V Raman via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv368ghhwe.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=40688@debbugs.gnu.org \
--cc=raman@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.